You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by mike-jumper <gi...@git.apache.org> on 2018/05/27 22:45:43 UTC
[GitHub] guacamole-client pull request #290: GUACAMOLE-567: Warn if network connectio...
GitHub user mike-jumper opened a pull request:
https://github.com/apache/guacamole-client/pull/290
GUACAMOLE-567: Warn if network connection appears unstable.
This change adds an additional `UNSTABLE` tunnel status to the JavaScript API, allowing the tunnels to report unstable network conditions in a potentially implementation-dependent way. The web application has been modified to display this as a small warning notification in the lower-left corner of the client screen:
Both the HTTP and WebSocket tunnels currently implement this by tracking the last time any data was received from the server at all (not the time since last frame, but the time since *any* data was received), flagging themselves as unstable if no data has been received for at least 2 seconds.
Additional handling of HTTP and WebSocket error codes has also been added, such that network errors reported by the browser are recognized as such.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mike-jumper/guacamole-client network-status
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/guacamole-client/pull/290.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #290
----
commit a1e59b9d3aa9b7fda49b9eb5e081700f46580b97
Author: Michael Jumper <mj...@...>
Date: 2017-12-11T01:46:11Z
GUACAMOLE-567: Add HTTP and WebSocket translation functions to Guacamole.Status.Code.
commit ca98d07b4abe8f37a0d8eb51bd4a4043cbc2c3d1
Author: Michael Jumper <mj...@...>
Date: 2017-12-11T00:56:19Z
GUACAMOLE-567: Rely on HTTP or WebSocket status code to determine error if Guacamole-specific reason is missing. Default to server unreachable.
commit e6f36659954653271495ee2c12cd80469a2ee63a
Author: Michael Jumper <mj...@...>
Date: 2017-12-11T04:22:22Z
GUACAMOLE-567: Add UNSTABLE tunnel status. Mark tunnel as UNSTABLE if no data has been received in a reasonable amount of time, but the tunnel is technically still open.
commit c04a0378af072eb4ff1a1430db29939450c61f62
Author: Michael Jumper <mj...@...>
Date: 2017-12-11T04:28:35Z
GUACAMOLE-567: Warn user when tunnel enters "UNSTABLE" state.
commit 8c3d6397dac8eacaec669a6f35d91ec53d8b89df
Author: Michael Jumper <mj...@...>
Date: 2018-05-27T22:27:17Z
GUACAMOLE-567: Clean up style of connection stability warning. Add warning icon.
----
---
[GitHub] guacamole-client pull request #290: GUACAMOLE-567: Warn if network connectio...
Posted by necouchman <gi...@git.apache.org>.
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/290#discussion_r191091208
--- Diff: guacamole/src/main/webapp/app/client/types/ManagedClient.js ---
@@ -346,6 +346,18 @@ angular.module('client').factory('ManagedClient', ['$rootScope', '$injector',
ManagedClientState.ConnectionState.CONNECTING);
break;
+ // Connection is being established
--- End diff --
Is being established? Or is established?
---
[GitHub] guacamole-client pull request #290: GUACAMOLE-567: Warn if network connectio...
Posted by mike-jumper <gi...@git.apache.org>.
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/290#discussion_r191092251
--- Diff: guacamole/src/main/webapp/app/client/types/ManagedClient.js ---
@@ -346,6 +346,18 @@ angular.module('client').factory('ManagedClient', ['$rootScope', '$injector',
ManagedClientState.ConnectionState.CONNECTING);
break;
+ // Connection is being established
--- End diff --
Oops. Definitely should be "is established".
---
[GitHub] guacamole-client pull request #290: GUACAMOLE-567: Warn if network connectio...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/guacamole-client/pull/290
---