[GitHub] [ozone] rakeshadr commented on a change in pull request #2108: HDDS-5061. Improve block commit

[GitBox <gi...@apache.org>]

rakeshadr commented on a change in pull request #2108:
URL: https://github.com/apache/ozone/pull/2108#discussion_r615686509



##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/multipart/S3MultipartUploadCompleteRequest.java
##########
@@ -285,7 +285,7 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
           // But now as versioning is not supported, just following the commit
           // key approach. When versioning support comes, then we can uncomment
           // below code keyInfo.addNewVersion(locations);
-          omKeyInfo.updateLocationInfoList(partLocationInfos, true);
+          omKeyInfo.updateLocationInfoList(partLocationInfos, true, true);

Review comment:
       Thanks @xiaoyuyao for the comment.
   
   Please refer [MPU test case](https://github.com/apache/ozone/blob/master/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestOzoneRpcClientAbstract.java#L2362), here MPU key has been overridden and the existing OM behavior is that it allows updated block locations of an existing MPU key. Thats the reason for skipping the blockID check on S3MultipartUploadCompleteRequest. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org