You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/12/01 20:11:56 UTC
Review Request 64257: Included `stout/os/realpath.hpp` where
`os::realpath()` is used.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64257/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos
Description
-------
Included `stout/os/realpath.hpp` where `os::realpath()` is used.
Diffs
-----
src/cli/mesos.cpp b347f395712da15729563e23b4a05c26434895ac
src/csi/paths.cpp 6caefc5af8ed94a9d4ea4a325e94b71883ac622d
src/examples/balloon_framework.cpp 0136344c160ea6aeacc57e61382640689a77ee1a
src/examples/long_lived_framework.cpp e6742159108f9eae4f2548bb84d6495309737d9c
src/examples/test_framework.cpp c6a293ed5f88bf4d73f23d97cbf9ffdd8b941f1a
src/examples/test_http_framework.cpp 373035837f51e818629b1588d2ab8803c656f527
src/files/files.cpp fbff2078312ea31bb120f8ba7584b53b4a607609
src/linux/cgroups.cpp 0a7bb89567d4b3ecee7c4f9a259368fb4eae7f34
src/linux/systemd.cpp 6318f48fc3c56d2414a8a50fd2d9debe74fddeb9
src/slave/containerizer/fetcher.cpp 8c4b7e6baefba116cd63c2275c90793a31ae12ec
src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 134ae5d545ba9fa49f47e3f1afbe6cce3580c1c8
src/slave/containerizer/mesos/isolators/filesystem/linux.cpp f40ded73824d42117951d05067ec89131f4e9b34
src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 270d2aa6e06f323bfb6eee3b703a24a600a55871
src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 1c207009b9d718093eae03b411813104ea34a9d7
src/slave/containerizer/mesos/isolators/volume/host_path.cpp 409fc148dcb89dfec18d77c5381ad547337eec8a
src/slave/containerizer/mesos/launch.cpp b1065be0d12934e9b10feadb7d1b82af8ad7cebc
src/slave/containerizer/mesos/provisioner/appc/store.cpp 9e65990c71e991247c35a9b84b69274e113fad6a
src/slave/containerizer/mesos/provisioner/backends/overlay.cpp 3149220316b901c0986d8546504d8ee78bec7181
src/slave/containerizer/mesos/provisioner/provisioner.cpp 81d2f93673e890f135e87ad86f30dfa16ea683ae
src/slave/slave.cpp 3896e432fe4b40a458e75537ccfcdd689cdf3f43
src/slave/state.cpp d49c38eada220c379f88acadb3522b1a112ab051
src/tests/containerizer/provisioner_appc_tests.cpp 9c4b685654acbdece730d1663aa8d54706763a21
src/tests/containerizer/rootfs.cpp fe9252dff859c2b08f609140ead2ef123844fbed
src/tests/gc_tests.cpp 6f055b5eb2a201401ca7dde93275b2d28a886a3c
src/tests/script.cpp 8d40e01da005cb05e7804f0b3975e3e0edb8f3bd
Diff: https://reviews.apache.org/r/64257/diff/1/
Testing
-------
See end of chain.
This is the `mesos` portion.
Thanks,
Andrew Schwartzmeyer
Re: Review Request 64257: Included `stout/os/realpath.hpp` where
`os::realpath()` is used.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64257/#review192571
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Dec. 1, 2017, 8:11 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64257/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2017, 8:11 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Included `stout/os/realpath.hpp` where `os::realpath()` is used.
>
>
> Diffs
> -----
>
> src/cli/mesos.cpp b347f395712da15729563e23b4a05c26434895ac
> src/csi/paths.cpp 6caefc5af8ed94a9d4ea4a325e94b71883ac622d
> src/examples/balloon_framework.cpp 0136344c160ea6aeacc57e61382640689a77ee1a
> src/examples/long_lived_framework.cpp e6742159108f9eae4f2548bb84d6495309737d9c
> src/examples/test_framework.cpp c6a293ed5f88bf4d73f23d97cbf9ffdd8b941f1a
> src/examples/test_http_framework.cpp 373035837f51e818629b1588d2ab8803c656f527
> src/files/files.cpp fbff2078312ea31bb120f8ba7584b53b4a607609
> src/linux/cgroups.cpp 0a7bb89567d4b3ecee7c4f9a259368fb4eae7f34
> src/linux/systemd.cpp 6318f48fc3c56d2414a8a50fd2d9debe74fddeb9
> src/slave/containerizer/fetcher.cpp 8c4b7e6baefba116cd63c2275c90793a31ae12ec
> src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 134ae5d545ba9fa49f47e3f1afbe6cce3580c1c8
> src/slave/containerizer/mesos/isolators/filesystem/linux.cpp f40ded73824d42117951d05067ec89131f4e9b34
> src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 270d2aa6e06f323bfb6eee3b703a24a600a55871
> src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 1c207009b9d718093eae03b411813104ea34a9d7
> src/slave/containerizer/mesos/isolators/volume/host_path.cpp 409fc148dcb89dfec18d77c5381ad547337eec8a
> src/slave/containerizer/mesos/launch.cpp b1065be0d12934e9b10feadb7d1b82af8ad7cebc
> src/slave/containerizer/mesos/provisioner/appc/store.cpp 9e65990c71e991247c35a9b84b69274e113fad6a
> src/slave/containerizer/mesos/provisioner/backends/overlay.cpp 3149220316b901c0986d8546504d8ee78bec7181
> src/slave/containerizer/mesos/provisioner/provisioner.cpp 81d2f93673e890f135e87ad86f30dfa16ea683ae
> src/slave/slave.cpp 3896e432fe4b40a458e75537ccfcdd689cdf3f43
> src/slave/state.cpp d49c38eada220c379f88acadb3522b1a112ab051
> src/tests/containerizer/provisioner_appc_tests.cpp 9c4b685654acbdece730d1663aa8d54706763a21
> src/tests/containerizer/rootfs.cpp fe9252dff859c2b08f609140ead2ef123844fbed
> src/tests/gc_tests.cpp 6f055b5eb2a201401ca7dde93275b2d28a886a3c
> src/tests/script.cpp 8d40e01da005cb05e7804f0b3975e3e0edb8f3bd
>
>
> Diff: https://reviews.apache.org/r/64257/diff/1/
>
>
> Testing
> -------
>
> See end of chain.
>
> This is the `mesos` portion.
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>