[jira] [Commented] (PHOENIX-4358) Case Sensitive String match on SqlType in PDataType

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-4358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243561#comment-16243561 ] 

Hadoop QA commented on PHOENIX-4358:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12896574/caseFix.patch
  against master branch at commit 4a1f0df6143ba705a48b5051aee52dab158afe8d.
  ATTACHMENT ID: 12896574

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.join.HashJoinNoIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ViewIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1621//testReport/
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1621//console

This message is automatically generated.

> Case Sensitive String match on SqlType in PDataType
> ---------------------------------------------------
>
>                 Key: PHOENIX-4358
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4358
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.11.0
>         Environment: OSX and Linux
>            Reporter: Dave Angulo
>            Priority: Minor
>         Attachments: caseFix.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> fromSqlTypeName() method uses a case sensitive match on input SqlType. This causes an issue in Spark JDBCUtils.makeSetter() which lowerCases input. The result is the error  _Unsupported sql type: varchar_.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)