You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Lance Norskog (JIRA)" <ji...@apache.org> on 2010/10/20 07:27:23 UTC
[jira] Created: (SOLR-2180) Requests to Embedded Solr (often) leave
old Searchers open
Requests to Embedded Solr (often) leave old Searchers open
----------------------------------------------------------
Key: SOLR-2180
URL: https://issues.apache.org/jira/browse/SOLR-2180
Project: Solr
Issue Type: Bug
Components: search
Affects Versions: 1.4.2, 1.5, 3.1, 4.0
Reporter: Lance Norskog
SolrEmbeddedServer.request() fails to call SolrQueryRequest.close() at the very end of a successful request. This (in some situations) causes EmbeddedSolr to leave old Searchers open until the Solr core stops (core unload, the JVM restarts). This leaves old Solr and Lucene caches in place, which causes a memory leak.
A fix for this was committed on the trunk on Sunday, Oct/15/2010.
[Revision r1023599 to SolrEmbeddedServer|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/src/webapp/src/org/apache/solr/client/solrj/embedded/EmbeddedSolrServer.java?diff_format=h&revision=1023599&view=markup]
This should be backported, or the problem checked for, in 1.4.2 and 3.1.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Resolved: (SOLR-2180) Requests to Embedded Solr (often)
leave old Searchers open
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yonik Seeley resolved SOLR-2180.
--------------------------------
Resolution: Fixed
Fix Version/s: 4.0
3.1
1.4.2
I packported to 3.x and 1.4.x
It's unclear exactly what would have triggered this bug... the SearchHandler.handleRequest normally catches exceptions and returns normally, so a normal query exception wouldn't have. I'm sure there were some ways though.
> Requests to Embedded Solr (often) leave old Searchers open
> ----------------------------------------------------------
>
> Key: SOLR-2180
> URL: https://issues.apache.org/jira/browse/SOLR-2180
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.4.2, 1.5, 3.1, 4.0
> Reporter: Lance Norskog
> Fix For: 1.4.2, 3.1, 4.0
>
>
> SolrEmbeddedServer.request() fails to call SolrQueryRequest.close() at the very end of a successful request. This (in some situations) causes EmbeddedSolr to leave old Searchers open until the Solr core stops (core unload, the JVM restarts). This leaves old Solr and Lucene caches in place, which causes a memory leak.
> A fix for this was committed on the trunk on Sunday, Oct/15/2010.
> [Revision r1023599 to SolrEmbeddedServer|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/src/webapp/src/org/apache/solr/client/solrj/embedded/EmbeddedSolrServer.java?diff_format=h&revision=1023599&view=markup]
> This should be backported, or the problem checked for, in 1.4.2 and 3.1.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (SOLR-2180) Requests to Embedded Solr (often)
leave old Searchers open
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923491#action_12923491 ]
Yonik Seeley commented on SOLR-2180:
------------------------------------
My reading of it was that it was only on an exception would the request not be closed (which is still a serious bug though).
I was cranking on tests and overlooked that this change had a broader impact.
> Requests to Embedded Solr (often) leave old Searchers open
> ----------------------------------------------------------
>
> Key: SOLR-2180
> URL: https://issues.apache.org/jira/browse/SOLR-2180
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.4.2, 1.5, 3.1, 4.0
> Reporter: Lance Norskog
>
> SolrEmbeddedServer.request() fails to call SolrQueryRequest.close() at the very end of a successful request. This (in some situations) causes EmbeddedSolr to leave old Searchers open until the Solr core stops (core unload, the JVM restarts). This leaves old Solr and Lucene caches in place, which causes a memory leak.
> A fix for this was committed on the trunk on Sunday, Oct/15/2010.
> [Revision r1023599 to SolrEmbeddedServer|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/src/webapp/src/org/apache/solr/client/solrj/embedded/EmbeddedSolrServer.java?diff_format=h&revision=1023599&view=markup]
> This should be backported, or the problem checked for, in 1.4.2 and 3.1.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org