You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/09/24 00:48:20 UTC
[GitHub] [kafka] mjsax commented on a change in pull request #8864: KAFKA-9274: Mark `retries` config as deprecated and add new `task.timeout.ms` config
mjsax commented on a change in pull request #8864:
URL: https://github.com/apache/kafka/pull/8864#discussion_r493976743
##########
File path: streams/src/test/java/org/apache/kafka/streams/tests/StreamsBrokerDownResilienceTest.java
##########
@@ -45,6 +45,7 @@
private static final String SINK_TOPIC = "streamsResilienceSink";
+ @SuppressWarnings("deprecation") // TODO revisit in follow up PR
Review comment:
Reverted via #9333
##########
File path: streams/src/test/java/org/apache/kafka/streams/tests/StreamsBrokerDownResilienceTest.java
##########
@@ -122,6 +123,7 @@ public void apply(final String key, final String value) {
});
}
+ @SuppressWarnings("deprecation") // TODO revisit in follow up PR
Review comment:
Reverted via #9333
##########
File path: streams/src/test/java/org/apache/kafka/streams/tests/StreamsOptimizedTest.java
##########
@@ -49,7 +49,7 @@
public class StreamsOptimizedTest {
-
+ @SuppressWarnings("deprecation") // TODO revisit in follow up PR
Review comment:
Reverted via #9333
##########
File path: streams/src/test/java/org/apache/kafka/streams/tests/StreamsStandByReplicaTest.java
##########
@@ -43,6 +43,7 @@
public class StreamsStandByReplicaTest {
+ @SuppressWarnings("deprecation") // TODO revisit in follow up PR
Review comment:
Reverted via #9333
##########
File path: streams/src/test/java/org/apache/kafka/streams/tests/StreamsStandByReplicaTest.java
##########
@@ -158,6 +159,7 @@ private static void shutdown(final KafkaStreams streams) {
streams.close(Duration.ofSeconds(10));
}
+ @SuppressWarnings("deprecation") // TODO revisit in follow up PR
Review comment:
Reverted via #9333
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org