You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/24 05:23:55 UTC

[GitHub] [pulsar] michaeljmarshall opened a new pull request #12955: [Authn] Deprecate AuthenticationDataSource#authenticate; Update SASL …

michaeljmarshall opened a new pull request #12955:
URL: https://github.com/apache/pulsar/pull/12955


   …Auth Implementation
   
   Master Issue: PIP 97 https://github.com/apache/pulsar/issues/12105
   
   ### Motivation
   
   When the SASL Authentication Provider was created, it introduced an `authenticate` method into the `AuthenticationDataSource`. This method is not necessary, and was marked as deprecated in PIP 97: https://github.com/apache/pulsar/issues/12105. This PR breaks the SASL Authentication Provider's reliance on the `AuthenticationDataSource#authenticate` method.
   
   As an added benefit, the `AuthenticationDataSource` is only a data source now. It is no longer overloaded as a data source _and_ a means of authenticating data.
   
   I plan to submit a subsequent PR to remove the `SaslAuthenticationDataSource`. This change is valuable by itself because it removes the reliance on `AuthenticationDataSource#authenticate`.
   
   Note also that `SaslAuthenticationState#authenticate` is also deprecated in PIP 97. I want to first get this merged before moving to the async variant.
   
   ### Modifications
   
   * Update `SaslAuthenticationDataSource` to remove unnecessary method declarations.
   * Update constructor for `SaslAuthenticationState` to only take the `PulsarSaslServer` as a parameter.
   * Update implementation of several methods in `SaslAuthenticationState` so that they no longer rely on the `SaslAuthenticationDataSource`.
   
   ### Verifying this change
   
   This change is internal to the SASL provider itself. It is covered by existing tests.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API: no
     - The schema: no
     - The default values of configurations: no
     - The wire protocol: no
     - The rest endpoints: no
     - The admin cli options: no
     - Anything that affects deployment: no
   
   ### Documentation
   
   - [x] `no-need-doc` 
   
   This is a completely internal update, so no docs need updating.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat merged pull request #12955: [PIP 97][SASL Authentication] Remove Deprecated SASL AuthenticationDataSource#authenticate Implementation

Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #12955:
URL: https://github.com/apache/pulsar/pull/12955


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] michaeljmarshall commented on pull request #12955: [SASL Authentication] Remove Deprecated SASL AuthenticationDataSource#authenticate Implementation

Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #12955:
URL: https://github.com/apache/pulsar/pull/12955#issuecomment-977546285


   @jiazhai, @merlimat, @eolivelli - PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] michaeljmarshall commented on pull request #12955: [PIP 97][SASL Authentication] Remove Deprecated SASL AuthenticationDataSource#authenticate Implementation

Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #12955:
URL: https://github.com/apache/pulsar/pull/12955#issuecomment-977581955


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org