[jira] [Commented] (TS-975) server-transform.c broken

["James Peach (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444171#comment-13444171 ] 

James Peach commented on TS-975:
--------------------------------

Otto, if this is still a problem, go ahead and commit :)
                
> server-transform.c broken
> -------------------------
>
>                 Key: TS-975
>                 URL: https://issues.apache.org/jira/browse/TS-975
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Plugins
>    Affects Versions: 3.0.0
>            Reporter: Otto van der Schaaf
>            Assignee: Otto van der Schaaf
>            Priority: Minor
>             Fix For: 3.3.1
>
>         Attachments: server-transform.c.diff
>
>
> While playing around with the server-transform plugin example, i noticed it
> was broken. After some meddling around, i got it working again.
> The changes are mainly that in some cases content-length was passed in
> network-byte order where it shouldn't be.
> Another fix was handling the TS_EVENT_IMMEDIATE event
> in transform_write_event(). i currently perform
> a TSVIOReenable(data->server_vio); on that event, and it seems to work.
> However, I'm not sure at all if that is the correct thing to do, so if
> anybody could help me out on that? :-).
> I have tested the changed code with a custom echo server, and confirmed that
> the plugin is actually sending and receiving to the echo server.
> I added the working code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira