You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2022/08/29 15:24:02 UTC

[GitHub] [cordova-plugin-device-orientation] mgurzixo commented on pull request #78: feat(android)!: rewrite native code to replace TYPE_ORIENTATION w/ TYPE_ACCELEROMETER & TYPE_MAGNETIC_FIELD

mgurzixo commented on PR #78:
URL: https://github.com/apache/cordova-plugin-device-orientation/pull/78#issuecomment-1230470370

   Hi!
   
   Sounds good, this is my first PR on Github. I fully agree with all the remarks; maybe put an uppercase on "Use ...".
   
   Is there anything I have to do?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org