You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/08/06 19:26:29 UTC

[GitHub] Noremac201 opened a new pull request #3711: [AIRFLOW-2863] Fix GKEClusterHook catching wrong exception

Noremac201 opened a new pull request #3711: [AIRFLOW-2863] Fix GKEClusterHook catching wrong exception
URL: https://github.com/apache/incubator-airflow/pull/3711
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title.
   
     - https://issues.apache.org/jira/browse/AIRFLOW-2863
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   GKEClusterHook was catching the wrong exception than it was expecting, and therefore would fail instead of succeeding. This fixes that.
   
   ### Tests
   -`test_create_cluster_already_exists`
   -`test_cluter_delete_not_found`
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Code Quality
   
   - [x] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services