You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/10/20 17:55:37 UTC

[GitHub] [kafka] guozhangwang opened a new pull request #9464: KAFKA-10616: Always call prepare-commit before suspending for active tasks

guozhangwang opened a new pull request #9464:
URL: https://github.com/apache/kafka/pull/9464


   Today for active tasks we the following active task suspension:
   
   1) closeAndRevive in handleTaskCorruption.
   2) closeClean in assignor#onAssignment.
   3) closeClean in shutdown.
   4) closeDirty in assignor#onAssignment.
   5) closeDirty in listener#onPartitionsLost.
   6) closeDirty in shutdown.
   7) suspend in listener#onPartitionsRevoked.
   
   Among those, 1/4/5/6 do not call prepareCommit which would `stateManager#flushCache` and may cause illegal state manager. This PR would require a prepareCommit triggered before suspend.
   
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] guozhangwang merged pull request #9464: KAFKA-10616: Always call prepare-commit before suspending for active tasks

Posted by GitBox <gi...@apache.org>.
guozhangwang merged pull request #9464:
URL: https://github.com/apache/kafka/pull/9464


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] guozhangwang commented on pull request #9464: KAFKA-10616: Always call prepare-commit before suspending for active tasks

Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #9464:
URL: https://github.com/apache/kafka/pull/9464#issuecomment-713182527


   @ableegoldman this PR is ready for review and merge.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] guozhangwang commented on pull request #9464: KAFKA-10616: Always call prepare-commit before suspending for active tasks

Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #9464:
URL: https://github.com/apache/kafka/pull/9464#issuecomment-716859719


   Cherry-picked to 2.7, cc @bbejeck 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org