You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2021/11/03 12:14:03 UTC

[GitHub] [drill] cgivre commented on pull request #2332: DRILL-7863: Add Storage Plugin for Apache Phoenix

cgivre commented on pull request #2332:
URL: https://github.com/apache/drill/pull/2332#issuecomment-958973388


   @luocooong Thanks for this PR.  This will be a really great addition to Drill!   I wanted to suggest that since there isn't a testcontainer for Apache Phoenix, that it might be a better approach to use the Phoenix test classes.  Here's one that I found: https://github.com/apache/phoenix/blob/master/phoenix-core/src/test/java/org/apache/phoenix/query/BaseTest.java
   
   Maybe take a look and see what you think.   From my recollection, this is what we had to do with the Splunk connector.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org