You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Fero Szabo via Review Board <no...@reviews.apache.org> on 2018/11/20 14:55:53 UTC

Review Request 69407: Refactor: break up Parameterized tests on a per database basis

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69407/
-----------------------------------------------------------

Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas.


Bugs: SQOOP-3405
    https://issues.apache.org/jira/browse/SQOOP-3405


Repository: sqoop-trunk


Description
-------

Breaking up the parameterized test classes into a per database basis. Provides better readability, needed for proper test categorization (and thus, for travis integration).


Diffs
-----

  src/test/org/apache/sqoop/importjob/DatabaseAdapterFactory.java PRE-CREATION 
  src/test/org/apache/sqoop/importjob/NumericTypesImportTest.java af310cbe2 
  src/test/org/apache/sqoop/importjob/SplitByImportTest.java 90b7cbbd3 
  src/test/org/apache/sqoop/importjob/configuration/MSSQLServerImportJobTestConfiguration.java 4ad7defe1 
  src/test/org/apache/sqoop/importjob/configuration/MySQLImportJobTestConfiguration.java fbcbdebeb 
  src/test/org/apache/sqoop/importjob/numerictypes/MysqlNumericTypesImportTest.java PRE-CREATION 
  src/test/org/apache/sqoop/importjob/numerictypes/OracleNumericTypesImportTest.java PRE-CREATION 
  src/test/org/apache/sqoop/importjob/numerictypes/PostgresNumericTypesImportTest.java PRE-CREATION 
  src/test/org/apache/sqoop/importjob/numerictypes/SqlServerNumericTypesImportTest.java PRE-CREATION 
  src/test/org/apache/sqoop/importjob/splitby/MysqlSplitByImportTest.java PRE-CREATION 
  src/test/org/apache/sqoop/importjob/splitby/OracleSplitByImportTest.java PRE-CREATION 
  src/test/org/apache/sqoop/importjob/splitby/PostgresSplitByImportTest.java PRE-CREATION 
  src/test/org/apache/sqoop/importjob/splitby/SqlServerSplitByImportTest.java PRE-CREATION 
  src/test/org/apache/sqoop/testutil/adapter/MSSQLServerDatabaseAdapter.java 22567162d 
  src/test/org/apache/sqoop/testutil/adapter/MySqlDatabaseAdapter.java ebd014688 


Diff: https://reviews.apache.org/r/69407/diff/1/


Testing
-------

unit and 3rd party tests.


Thanks,

Fero Szabo

Re: Review Request 69407: Refactor: break up Parameterized tests on a per database basis

Posted by Fero Szabo via Review Board <no...@reviews.apache.org>.

> On Nov. 21, 2018, 2:05 p.m., Boglarka Egyed wrote:
> > src/test/org/apache/sqoop/importjob/numerictypes/OracleNumericTypesImportTest.java
> > Lines 1 (patched)
> > <https://reviews.apache.org/r/69407/diff/5/?file=2109510#file2109510line1>
> >
> >     Apache headers are missing from new files.

Thanks for pointing this out, should be ok now. I didn't make any other code change, just added the licence headers, but Reviewboard somehow shows more...


- Fero


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69407/#review210762
-----------------------------------------------------------


On Nov. 21, 2018, 3 p.m., Fero Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69407/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2018, 3 p.m.)
> 
> 
> Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3405
>     https://issues.apache.org/jira/browse/SQOOP-3405
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Breaking up the parameterized test classes into a per database basis. Provides better readability, needed for proper test categorization (and thus, for travis integration).
> 
> 
> Diffs
> -----
> 
>   src/test/org/apache/sqoop/importjob/DatabaseAdapterFactory.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/NumericTypesImportTest.java af310cb 
>   src/test/org/apache/sqoop/importjob/SplitByImportTest.java 90b7cbb 
>   src/test/org/apache/sqoop/importjob/configuration/MSSQLServerImportJobTestConfiguration.java 4ad7def 
>   src/test/org/apache/sqoop/importjob/configuration/MySQLImportJobTestConfiguration.java fbcbdeb 
>   src/test/org/apache/sqoop/importjob/configuration/MysqlImportJobTestConfiguration.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/configuration/SqlServerImportJobTestConfiguration.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/numerictypes/MysqlNumericTypesImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/numerictypes/NumericTypesImportTestBase.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/numerictypes/OracleNumericTypesImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/numerictypes/PostgresNumericTypesImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/numerictypes/SqlServerNumericTypesImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/splitby/MysqlSplitByImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/splitby/OracleSplitByImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/splitby/PostgresSplitByImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/splitby/SplitByImportTestBase.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/splitby/SqlServerSplitByImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/testutil/adapter/MSSQLServerDatabaseAdapter.java 2256716 
>   src/test/org/apache/sqoop/testutil/adapter/MySqlDatabaseAdapter.java ebd0146 
>   src/test/org/apache/sqoop/testutil/adapter/MysqlDatabaseAdapter.java PRE-CREATION 
>   src/test/org/apache/sqoop/testutil/adapter/SqlServerDatabaseAdapter.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/69407/diff/6/
> 
> 
> Testing
> -------
> 
> unit and 3rd party tests.
> 
> 
> Thanks,
> 
> Fero Szabo
> 
>

Re: Review Request 69407: Refactor: break up Parameterized tests on a per database basis

Posted by Boglarka Egyed <bo...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69407/#review210762
-----------------------------------------------------------


Fix it, then Ship it!




Hi Fero,

Your change generally looks good to me, I only have a minor finding.

Unit and 3rd party tests passed with your patch.

Cheers,
Bogi


src/test/org/apache/sqoop/importjob/numerictypes/OracleNumericTypesImportTest.java
Lines 1 (patched)
<https://reviews.apache.org/r/69407/#comment295517>

    Apache headers are missing from new files.


- Boglarka Egyed


On Nov. 21, 2018, 10:20 a.m., Fero Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69407/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2018, 10:20 a.m.)
> 
> 
> Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3405
>     https://issues.apache.org/jira/browse/SQOOP-3405
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Breaking up the parameterized test classes into a per database basis. Provides better readability, needed for proper test categorization (and thus, for travis integration).
> 
> 
> Diffs
> -----
> 
>   src/test/org/apache/sqoop/importjob/DatabaseAdapterFactory.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/NumericTypesImportTest.java af310cbe 
>   src/test/org/apache/sqoop/importjob/SplitByImportTest.java 90b7cbbd 
>   src/test/org/apache/sqoop/importjob/configuration/MSSQLServerImportJobTestConfiguration.java 4ad7defe 
>   src/test/org/apache/sqoop/importjob/configuration/MySQLImportJobTestConfiguration.java fbcbdebe 
>   src/test/org/apache/sqoop/importjob/numerictypes/MysqlNumericTypesImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/numerictypes/OracleNumericTypesImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/numerictypes/PostgresNumericTypesImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/numerictypes/SqlServerNumericTypesImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/splitby/MysqlSplitByImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/splitby/OracleSplitByImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/splitby/PostgresSplitByImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/splitby/SqlServerSplitByImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/testutil/adapter/MSSQLServerDatabaseAdapter.java 22567162 
>   src/test/org/apache/sqoop/testutil/adapter/MySqlDatabaseAdapter.java ebd01468 
> 
> 
> Diff: https://reviews.apache.org/r/69407/diff/5/
> 
> 
> Testing
> -------
> 
> unit and 3rd party tests.
> 
> 
> Thanks,
> 
> Fero Szabo
> 
>

Re: Review Request 69407: Refactor: break up Parameterized tests on a per database basis

Posted by Szabolcs Vasas <va...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69407/#review210756
-----------------------------------------------------------


Ship it!




Hi Feró,

Thank you for improving these tests, unit and third party tests were both successful.

- Szabolcs Vasas


On Nov. 21, 2018, 10:20 a.m., Fero Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69407/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2018, 10:20 a.m.)
> 
> 
> Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3405
>     https://issues.apache.org/jira/browse/SQOOP-3405
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Breaking up the parameterized test classes into a per database basis. Provides better readability, needed for proper test categorization (and thus, for travis integration).
> 
> 
> Diffs
> -----
> 
>   src/test/org/apache/sqoop/importjob/DatabaseAdapterFactory.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/NumericTypesImportTest.java af310cbe 
>   src/test/org/apache/sqoop/importjob/SplitByImportTest.java 90b7cbbd 
>   src/test/org/apache/sqoop/importjob/configuration/MSSQLServerImportJobTestConfiguration.java 4ad7defe 
>   src/test/org/apache/sqoop/importjob/configuration/MySQLImportJobTestConfiguration.java fbcbdebe 
>   src/test/org/apache/sqoop/importjob/numerictypes/MysqlNumericTypesImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/numerictypes/OracleNumericTypesImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/numerictypes/PostgresNumericTypesImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/numerictypes/SqlServerNumericTypesImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/splitby/MysqlSplitByImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/splitby/OracleSplitByImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/splitby/PostgresSplitByImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/splitby/SqlServerSplitByImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/testutil/adapter/MSSQLServerDatabaseAdapter.java 22567162 
>   src/test/org/apache/sqoop/testutil/adapter/MySqlDatabaseAdapter.java ebd01468 
> 
> 
> Diff: https://reviews.apache.org/r/69407/diff/5/
> 
> 
> Testing
> -------
> 
> unit and 3rd party tests.
> 
> 
> Thanks,
> 
> Fero Szabo
> 
>

Re: Review Request 69407: Refactor: break up Parameterized tests on a per database basis

Posted by Boglarka Egyed <bo...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69407/#review210796
-----------------------------------------------------------


Ship it!




Ship It!

- Boglarka Egyed


On Nov. 22, 2018, 1:39 p.m., Fero Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69407/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2018, 1:39 p.m.)
> 
> 
> Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3405
>     https://issues.apache.org/jira/browse/SQOOP-3405
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Breaking up the parameterized test classes into a per database basis. Provides better readability, needed for proper test categorization (and thus, for travis integration).
> 
> 
> Diffs
> -----
> 
>   src/test/org/apache/sqoop/importjob/DatabaseAdapterFactory.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/NumericTypesImportTest.java af310cbe2 
>   src/test/org/apache/sqoop/importjob/SplitByImportTest.java 90b7cbbd3 
>   src/test/org/apache/sqoop/importjob/configuration/MSSQLServerImportJobTestConfiguration.java 4ad7defe1 
>   src/test/org/apache/sqoop/importjob/configuration/MySQLImportJobTestConfiguration.java fbcbdebeb 
>   src/test/org/apache/sqoop/importjob/numerictypes/MysqlNumericTypesImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/numerictypes/OracleNumericTypesImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/numerictypes/PostgresNumericTypesImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/numerictypes/SqlServerNumericTypesImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/splitby/MysqlSplitByImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/splitby/OracleSplitByImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/splitby/PostgresSplitByImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/splitby/SqlServerSplitByImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/testutil/adapter/MSSQLServerDatabaseAdapter.java 22567162d 
>   src/test/org/apache/sqoop/testutil/adapter/MySqlDatabaseAdapter.java ebd014688 
> 
> 
> Diff: https://reviews.apache.org/r/69407/diff/7/
> 
> 
> Testing
> -------
> 
> unit and 3rd party tests.
> 
> 
> Thanks,
> 
> Fero Szabo
> 
>

Re: Review Request 69407: Refactor: break up Parameterized tests on a per database basis

Posted by Szabolcs Vasas <va...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69407/#review210795
-----------------------------------------------------------


Ship it!




Ship It!

- Szabolcs Vasas


On Nov. 22, 2018, 1:39 p.m., Fero Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69407/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2018, 1:39 p.m.)
> 
> 
> Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3405
>     https://issues.apache.org/jira/browse/SQOOP-3405
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Breaking up the parameterized test classes into a per database basis. Provides better readability, needed for proper test categorization (and thus, for travis integration).
> 
> 
> Diffs
> -----
> 
>   src/test/org/apache/sqoop/importjob/DatabaseAdapterFactory.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/NumericTypesImportTest.java af310cbe2 
>   src/test/org/apache/sqoop/importjob/SplitByImportTest.java 90b7cbbd3 
>   src/test/org/apache/sqoop/importjob/configuration/MSSQLServerImportJobTestConfiguration.java 4ad7defe1 
>   src/test/org/apache/sqoop/importjob/configuration/MySQLImportJobTestConfiguration.java fbcbdebeb 
>   src/test/org/apache/sqoop/importjob/numerictypes/MysqlNumericTypesImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/numerictypes/OracleNumericTypesImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/numerictypes/PostgresNumericTypesImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/numerictypes/SqlServerNumericTypesImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/splitby/MysqlSplitByImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/splitby/OracleSplitByImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/splitby/PostgresSplitByImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/splitby/SqlServerSplitByImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/testutil/adapter/MSSQLServerDatabaseAdapter.java 22567162d 
>   src/test/org/apache/sqoop/testutil/adapter/MySqlDatabaseAdapter.java ebd014688 
> 
> 
> Diff: https://reviews.apache.org/r/69407/diff/7/
> 
> 
> Testing
> -------
> 
> unit and 3rd party tests.
> 
> 
> Thanks,
> 
> Fero Szabo
> 
>

Re: Review Request 69407: Refactor: break up Parameterized tests on a per database basis

Posted by Fero Szabo via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69407/
-----------------------------------------------------------

(Updated Nov. 22, 2018, 1:39 p.m.)


Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas.


Bugs: SQOOP-3405
    https://issues.apache.org/jira/browse/SQOOP-3405


Repository: sqoop-trunk


Description
-------

Breaking up the parameterized test classes into a per database basis. Provides better readability, needed for proper test categorization (and thus, for travis integration).


Diffs (updated)
-----

  src/test/org/apache/sqoop/importjob/DatabaseAdapterFactory.java PRE-CREATION 
  src/test/org/apache/sqoop/importjob/NumericTypesImportTest.java af310cbe2 
  src/test/org/apache/sqoop/importjob/SplitByImportTest.java 90b7cbbd3 
  src/test/org/apache/sqoop/importjob/configuration/MSSQLServerImportJobTestConfiguration.java 4ad7defe1 
  src/test/org/apache/sqoop/importjob/configuration/MySQLImportJobTestConfiguration.java fbcbdebeb 
  src/test/org/apache/sqoop/importjob/numerictypes/MysqlNumericTypesImportTest.java PRE-CREATION 
  src/test/org/apache/sqoop/importjob/numerictypes/OracleNumericTypesImportTest.java PRE-CREATION 
  src/test/org/apache/sqoop/importjob/numerictypes/PostgresNumericTypesImportTest.java PRE-CREATION 
  src/test/org/apache/sqoop/importjob/numerictypes/SqlServerNumericTypesImportTest.java PRE-CREATION 
  src/test/org/apache/sqoop/importjob/splitby/MysqlSplitByImportTest.java PRE-CREATION 
  src/test/org/apache/sqoop/importjob/splitby/OracleSplitByImportTest.java PRE-CREATION 
  src/test/org/apache/sqoop/importjob/splitby/PostgresSplitByImportTest.java PRE-CREATION 
  src/test/org/apache/sqoop/importjob/splitby/SqlServerSplitByImportTest.java PRE-CREATION 
  src/test/org/apache/sqoop/testutil/adapter/MSSQLServerDatabaseAdapter.java 22567162d 
  src/test/org/apache/sqoop/testutil/adapter/MySqlDatabaseAdapter.java ebd014688 


Diff: https://reviews.apache.org/r/69407/diff/7/

Changes: https://reviews.apache.org/r/69407/diff/6-7/


Testing
-------

unit and 3rd party tests.


Thanks,

Fero Szabo

Re: Review Request 69407: Refactor: break up Parameterized tests on a per database basis

Posted by Fero Szabo via Review Board <no...@reviews.apache.org>.

> On Nov. 22, 2018, 8:29 a.m., Boglarka Egyed wrote:
> > src/test/org/apache/sqoop/importjob/configuration/MysqlImportJobTestConfiguration.java
> > Lines 24 (patched)
> > <https://reviews.apache.org/r/69407/diff/6/?file=2109532#file2109532line24>
> >
> >     Renamed files are shown as new files now which compromises the diff. Could you please take a look and regenerate the diff?
> 
> Boglarka Egyed wrote:
>     Sorry, I wanted to say that it corrupts the diff.

Fixed with black-belt git magic, with the help of Szabi. ;)


- Fero


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69407/#review210785
-----------------------------------------------------------


On Nov. 22, 2018, 1:39 p.m., Fero Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69407/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2018, 1:39 p.m.)
> 
> 
> Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3405
>     https://issues.apache.org/jira/browse/SQOOP-3405
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Breaking up the parameterized test classes into a per database basis. Provides better readability, needed for proper test categorization (and thus, for travis integration).
> 
> 
> Diffs
> -----
> 
>   src/test/org/apache/sqoop/importjob/DatabaseAdapterFactory.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/NumericTypesImportTest.java af310cbe2 
>   src/test/org/apache/sqoop/importjob/SplitByImportTest.java 90b7cbbd3 
>   src/test/org/apache/sqoop/importjob/configuration/MSSQLServerImportJobTestConfiguration.java 4ad7defe1 
>   src/test/org/apache/sqoop/importjob/configuration/MySQLImportJobTestConfiguration.java fbcbdebeb 
>   src/test/org/apache/sqoop/importjob/numerictypes/MysqlNumericTypesImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/numerictypes/OracleNumericTypesImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/numerictypes/PostgresNumericTypesImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/numerictypes/SqlServerNumericTypesImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/splitby/MysqlSplitByImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/splitby/OracleSplitByImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/splitby/PostgresSplitByImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/splitby/SqlServerSplitByImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/testutil/adapter/MSSQLServerDatabaseAdapter.java 22567162d 
>   src/test/org/apache/sqoop/testutil/adapter/MySqlDatabaseAdapter.java ebd014688 
> 
> 
> Diff: https://reviews.apache.org/r/69407/diff/7/
> 
> 
> Testing
> -------
> 
> unit and 3rd party tests.
> 
> 
> Thanks,
> 
> Fero Szabo
> 
>

Re: Review Request 69407: Refactor: break up Parameterized tests on a per database basis

Posted by Boglarka Egyed <bo...@apache.org>.

> On Nov. 22, 2018, 8:29 a.m., Boglarka Egyed wrote:
> > src/test/org/apache/sqoop/importjob/configuration/MysqlImportJobTestConfiguration.java
> > Lines 24 (patched)
> > <https://reviews.apache.org/r/69407/diff/6/?file=2109532#file2109532line24>
> >
> >     Renamed files are shown as new files now which compromises the diff. Could you please take a look and regenerate the diff?

Sorry, I wanted to say that it corrupts the diff.


- Boglarka


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69407/#review210785
-----------------------------------------------------------


On Nov. 21, 2018, 3 p.m., Fero Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69407/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2018, 3 p.m.)
> 
> 
> Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3405
>     https://issues.apache.org/jira/browse/SQOOP-3405
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Breaking up the parameterized test classes into a per database basis. Provides better readability, needed for proper test categorization (and thus, for travis integration).
> 
> 
> Diffs
> -----
> 
>   src/test/org/apache/sqoop/importjob/DatabaseAdapterFactory.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/NumericTypesImportTest.java af310cb 
>   src/test/org/apache/sqoop/importjob/SplitByImportTest.java 90b7cbb 
>   src/test/org/apache/sqoop/importjob/configuration/MSSQLServerImportJobTestConfiguration.java 4ad7def 
>   src/test/org/apache/sqoop/importjob/configuration/MySQLImportJobTestConfiguration.java fbcbdeb 
>   src/test/org/apache/sqoop/importjob/configuration/MysqlImportJobTestConfiguration.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/configuration/SqlServerImportJobTestConfiguration.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/numerictypes/MysqlNumericTypesImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/numerictypes/NumericTypesImportTestBase.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/numerictypes/OracleNumericTypesImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/numerictypes/PostgresNumericTypesImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/numerictypes/SqlServerNumericTypesImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/splitby/MysqlSplitByImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/splitby/OracleSplitByImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/splitby/PostgresSplitByImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/splitby/SplitByImportTestBase.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/splitby/SqlServerSplitByImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/testutil/adapter/MSSQLServerDatabaseAdapter.java 2256716 
>   src/test/org/apache/sqoop/testutil/adapter/MySqlDatabaseAdapter.java ebd0146 
>   src/test/org/apache/sqoop/testutil/adapter/MysqlDatabaseAdapter.java PRE-CREATION 
>   src/test/org/apache/sqoop/testutil/adapter/SqlServerDatabaseAdapter.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/69407/diff/6/
> 
> 
> Testing
> -------
> 
> unit and 3rd party tests.
> 
> 
> Thanks,
> 
> Fero Szabo
> 
>

Re: Review Request 69407: Refactor: break up Parameterized tests on a per database basis

Posted by Boglarka Egyed <bo...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69407/#review210785
-----------------------------------------------------------




src/test/org/apache/sqoop/importjob/configuration/MysqlImportJobTestConfiguration.java
Lines 24 (patched)
<https://reviews.apache.org/r/69407/#comment295545>

    Renamed files are shown as new files now which compromises the diff. Could you please take a look and regenerate the diff?


- Boglarka Egyed


On Nov. 21, 2018, 3 p.m., Fero Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69407/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2018, 3 p.m.)
> 
> 
> Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3405
>     https://issues.apache.org/jira/browse/SQOOP-3405
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Breaking up the parameterized test classes into a per database basis. Provides better readability, needed for proper test categorization (and thus, for travis integration).
> 
> 
> Diffs
> -----
> 
>   src/test/org/apache/sqoop/importjob/DatabaseAdapterFactory.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/NumericTypesImportTest.java af310cb 
>   src/test/org/apache/sqoop/importjob/SplitByImportTest.java 90b7cbb 
>   src/test/org/apache/sqoop/importjob/configuration/MSSQLServerImportJobTestConfiguration.java 4ad7def 
>   src/test/org/apache/sqoop/importjob/configuration/MySQLImportJobTestConfiguration.java fbcbdeb 
>   src/test/org/apache/sqoop/importjob/configuration/MysqlImportJobTestConfiguration.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/configuration/SqlServerImportJobTestConfiguration.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/numerictypes/MysqlNumericTypesImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/numerictypes/NumericTypesImportTestBase.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/numerictypes/OracleNumericTypesImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/numerictypes/PostgresNumericTypesImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/numerictypes/SqlServerNumericTypesImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/splitby/MysqlSplitByImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/splitby/OracleSplitByImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/splitby/PostgresSplitByImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/splitby/SplitByImportTestBase.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/splitby/SqlServerSplitByImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/testutil/adapter/MSSQLServerDatabaseAdapter.java 2256716 
>   src/test/org/apache/sqoop/testutil/adapter/MySqlDatabaseAdapter.java ebd0146 
>   src/test/org/apache/sqoop/testutil/adapter/MysqlDatabaseAdapter.java PRE-CREATION 
>   src/test/org/apache/sqoop/testutil/adapter/SqlServerDatabaseAdapter.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/69407/diff/6/
> 
> 
> Testing
> -------
> 
> unit and 3rd party tests.
> 
> 
> Thanks,
> 
> Fero Szabo
> 
>

Re: Review Request 69407: Refactor: break up Parameterized tests on a per database basis

Posted by Fero Szabo via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69407/
-----------------------------------------------------------

(Updated Nov. 21, 2018, 3 p.m.)


Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas.


Bugs: SQOOP-3405
    https://issues.apache.org/jira/browse/SQOOP-3405


Repository: sqoop-trunk


Description
-------

Breaking up the parameterized test classes into a per database basis. Provides better readability, needed for proper test categorization (and thus, for travis integration).


Diffs (updated)
-----

  src/test/org/apache/sqoop/importjob/DatabaseAdapterFactory.java PRE-CREATION 
  src/test/org/apache/sqoop/importjob/NumericTypesImportTest.java af310cb 
  src/test/org/apache/sqoop/importjob/SplitByImportTest.java 90b7cbb 
  src/test/org/apache/sqoop/importjob/configuration/MSSQLServerImportJobTestConfiguration.java 4ad7def 
  src/test/org/apache/sqoop/importjob/configuration/MySQLImportJobTestConfiguration.java fbcbdeb 
  src/test/org/apache/sqoop/importjob/configuration/MysqlImportJobTestConfiguration.java PRE-CREATION 
  src/test/org/apache/sqoop/importjob/configuration/SqlServerImportJobTestConfiguration.java PRE-CREATION 
  src/test/org/apache/sqoop/importjob/numerictypes/MysqlNumericTypesImportTest.java PRE-CREATION 
  src/test/org/apache/sqoop/importjob/numerictypes/NumericTypesImportTestBase.java PRE-CREATION 
  src/test/org/apache/sqoop/importjob/numerictypes/OracleNumericTypesImportTest.java PRE-CREATION 
  src/test/org/apache/sqoop/importjob/numerictypes/PostgresNumericTypesImportTest.java PRE-CREATION 
  src/test/org/apache/sqoop/importjob/numerictypes/SqlServerNumericTypesImportTest.java PRE-CREATION 
  src/test/org/apache/sqoop/importjob/splitby/MysqlSplitByImportTest.java PRE-CREATION 
  src/test/org/apache/sqoop/importjob/splitby/OracleSplitByImportTest.java PRE-CREATION 
  src/test/org/apache/sqoop/importjob/splitby/PostgresSplitByImportTest.java PRE-CREATION 
  src/test/org/apache/sqoop/importjob/splitby/SplitByImportTestBase.java PRE-CREATION 
  src/test/org/apache/sqoop/importjob/splitby/SqlServerSplitByImportTest.java PRE-CREATION 
  src/test/org/apache/sqoop/testutil/adapter/MSSQLServerDatabaseAdapter.java 2256716 
  src/test/org/apache/sqoop/testutil/adapter/MySqlDatabaseAdapter.java ebd0146 
  src/test/org/apache/sqoop/testutil/adapter/MysqlDatabaseAdapter.java PRE-CREATION 
  src/test/org/apache/sqoop/testutil/adapter/SqlServerDatabaseAdapter.java PRE-CREATION 


Diff: https://reviews.apache.org/r/69407/diff/6/

Changes: https://reviews.apache.org/r/69407/diff/5-6/


Testing
-------

unit and 3rd party tests.


Thanks,

Fero Szabo

Re: Review Request 69407: Refactor: break up Parameterized tests on a per database basis

Posted by Fero Szabo via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69407/
-----------------------------------------------------------

(Updated Nov. 21, 2018, 10:20 a.m.)


Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas.


Bugs: SQOOP-3405
    https://issues.apache.org/jira/browse/SQOOP-3405


Repository: sqoop-trunk


Description
-------

Breaking up the parameterized test classes into a per database basis. Provides better readability, needed for proper test categorization (and thus, for travis integration).


Diffs (updated)
-----

  src/test/org/apache/sqoop/importjob/DatabaseAdapterFactory.java PRE-CREATION 
  src/test/org/apache/sqoop/importjob/NumericTypesImportTest.java af310cbe 
  src/test/org/apache/sqoop/importjob/SplitByImportTest.java 90b7cbbd 
  src/test/org/apache/sqoop/importjob/configuration/MSSQLServerImportJobTestConfiguration.java 4ad7defe 
  src/test/org/apache/sqoop/importjob/configuration/MySQLImportJobTestConfiguration.java fbcbdebe 
  src/test/org/apache/sqoop/importjob/numerictypes/MysqlNumericTypesImportTest.java PRE-CREATION 
  src/test/org/apache/sqoop/importjob/numerictypes/OracleNumericTypesImportTest.java PRE-CREATION 
  src/test/org/apache/sqoop/importjob/numerictypes/PostgresNumericTypesImportTest.java PRE-CREATION 
  src/test/org/apache/sqoop/importjob/numerictypes/SqlServerNumericTypesImportTest.java PRE-CREATION 
  src/test/org/apache/sqoop/importjob/splitby/MysqlSplitByImportTest.java PRE-CREATION 
  src/test/org/apache/sqoop/importjob/splitby/OracleSplitByImportTest.java PRE-CREATION 
  src/test/org/apache/sqoop/importjob/splitby/PostgresSplitByImportTest.java PRE-CREATION 
  src/test/org/apache/sqoop/importjob/splitby/SqlServerSplitByImportTest.java PRE-CREATION 
  src/test/org/apache/sqoop/testutil/adapter/MSSQLServerDatabaseAdapter.java 22567162 
  src/test/org/apache/sqoop/testutil/adapter/MySqlDatabaseAdapter.java ebd01468 


Diff: https://reviews.apache.org/r/69407/diff/5/

Changes: https://reviews.apache.org/r/69407/diff/4-5/


Testing
-------

unit and 3rd party tests.


Thanks,

Fero Szabo

Re: Review Request 69407: Refactor: break up Parameterized tests on a per database basis

Posted by Fero Szabo via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69407/
-----------------------------------------------------------

(Updated Nov. 21, 2018, 9:31 a.m.)


Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas.


Bugs: SQOOP-3405
    https://issues.apache.org/jira/browse/SQOOP-3405


Repository: sqoop-trunk


Description
-------

Breaking up the parameterized test classes into a per database basis. Provides better readability, needed for proper test categorization (and thus, for travis integration).


Diffs (updated)
-----

  src/test/org/apache/sqoop/importjob/DatabaseAdapterFactory.java PRE-CREATION 
  src/test/org/apache/sqoop/importjob/NumericTypesImportTest.java af310cbe2 
  src/test/org/apache/sqoop/importjob/SplitByImportTest.java 90b7cbbd3 
  src/test/org/apache/sqoop/importjob/configuration/MSSQLServerImportJobTestConfiguration.java 4ad7defe1 
  src/test/org/apache/sqoop/importjob/configuration/MySQLImportJobTestConfiguration.java fbcbdebeb 
  src/test/org/apache/sqoop/importjob/numerictypes/MysqlNumericTypesImportTest.java PRE-CREATION 
  src/test/org/apache/sqoop/importjob/numerictypes/OracleNumericTypesImportTest.java PRE-CREATION 
  src/test/org/apache/sqoop/importjob/numerictypes/PostgresNumericTypesImportTest.java PRE-CREATION 
  src/test/org/apache/sqoop/importjob/numerictypes/SqlServerNumericTypesImportTest.java PRE-CREATION 
  src/test/org/apache/sqoop/importjob/splitby/MysqlSplitByImportTest.java PRE-CREATION 
  src/test/org/apache/sqoop/importjob/splitby/OracleSplitByImportTest.java PRE-CREATION 
  src/test/org/apache/sqoop/importjob/splitby/PostgresSplitByImportTest.java PRE-CREATION 
  src/test/org/apache/sqoop/importjob/splitby/SqlServerSplitByImportTest.java PRE-CREATION 
  src/test/org/apache/sqoop/testutil/adapter/MSSQLServerDatabaseAdapter.java 22567162d 
  src/test/org/apache/sqoop/testutil/adapter/MySqlDatabaseAdapter.java ebd014688 


Diff: https://reviews.apache.org/r/69407/diff/4/

Changes: https://reviews.apache.org/r/69407/diff/3-4/


Testing
-------

unit and 3rd party tests.


Thanks,

Fero Szabo

Re: Review Request 69407: Refactor: break up Parameterized tests on a per database basis

Posted by Fero Szabo via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69407/
-----------------------------------------------------------

(Updated Nov. 21, 2018, 9:29 a.m.)


Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas.


Bugs: SQOOP-3405
    https://issues.apache.org/jira/browse/SQOOP-3405


Repository: sqoop-trunk


Description
-------

Breaking up the parameterized test classes into a per database basis. Provides better readability, needed for proper test categorization (and thus, for travis integration).


Diffs (updated)
-----

  src/java/org/apache/sqoop/hive/HiveTypes.java 554a03608 
  src/java/org/apache/sqoop/hive/TableDefWriter.java b21dfe534 
  src/test/org/apache/sqoop/hive/TestHiveServer2ParquetImport.java 8cfd776d5 


Diff: https://reviews.apache.org/r/69407/diff/3/

Changes: https://reviews.apache.org/r/69407/diff/2-3/


Testing
-------

unit and 3rd party tests.


Thanks,

Fero Szabo

Re: Review Request 69407: Refactor: break up Parameterized tests on a per database basis

Posted by Fero Szabo via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69407/
-----------------------------------------------------------

(Updated Nov. 21, 2018, 9:07 a.m.)


Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas.


Changes
-------

Refactored test class names to the same as used in the categorization


Bugs: SQOOP-3405
    https://issues.apache.org/jira/browse/SQOOP-3405


Repository: sqoop-trunk


Description
-------

Breaking up the parameterized test classes into a per database basis. Provides better readability, needed for proper test categorization (and thus, for travis integration).


Diffs (updated)
-----

  src/java/org/apache/sqoop/hive/HiveTypes.java 554a03608 
  src/java/org/apache/sqoop/hive/TableDefWriter.java b21dfe534 
  src/test/org/apache/sqoop/hive/TestHiveServer2ParquetImport.java 8cfd776d5 


Diff: https://reviews.apache.org/r/69407/diff/2/

Changes: https://reviews.apache.org/r/69407/diff/1-2/


Testing
-------

unit and 3rd party tests.


Thanks,

Fero Szabo