You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@batchee.apache.org by rm...@apache.org on 2014/01/13 23:03:00 UTC

git commit: this test was useless

Updated Branches:
  refs/heads/master 2dacce435 -> 0a8765b44


this test was useless


Project: http://git-wip-us.apache.org/repos/asf/incubator-batchee/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-batchee/commit/0a8765b4
Tree: http://git-wip-us.apache.org/repos/asf/incubator-batchee/tree/0a8765b4
Diff: http://git-wip-us.apache.org/repos/asf/incubator-batchee/diff/0a8765b4

Branch: refs/heads/master
Commit: 0a8765b44e418735a8903504509e4976c1f0a674
Parents: 2dacce4
Author: Romain Manni-Bucau <rm...@apache.org>
Authored: Mon Jan 13 23:03:16 2014 +0100
Committer: Romain Manni-Bucau <rm...@apache.org>
Committed: Mon Jan 13 23:03:16 2014 +0100

----------------------------------------------------------------------
 .../apache/batchee/test/tck/lifecycle/ContainerLifecycle.java  | 6 ------
 .../org/apache/batchee/cli/command/JobOperatorCommand.java     | 1 -
 2 files changed, 7 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-batchee/blob/0a8765b4/jbatch/src/test/java/org/apache/batchee/test/tck/lifecycle/ContainerLifecycle.java
----------------------------------------------------------------------
diff --git a/jbatch/src/test/java/org/apache/batchee/test/tck/lifecycle/ContainerLifecycle.java b/jbatch/src/test/java/org/apache/batchee/test/tck/lifecycle/ContainerLifecycle.java
index 8982b67..d25c0c0 100644
--- a/jbatch/src/test/java/org/apache/batchee/test/tck/lifecycle/ContainerLifecycle.java
+++ b/jbatch/src/test/java/org/apache/batchee/test/tck/lifecycle/ContainerLifecycle.java
@@ -17,7 +17,6 @@
 package org.apache.batchee.test.tck.lifecycle;
 
 import org.apache.derby.jdbc.EmbeddedDriver;
-import org.apache.openejb.loader.SystemInstance;
 import org.apache.openejb.testng.PropertiesBuilder;
 import org.testng.ITestContext;
 import org.testng.ITestListener;
@@ -63,11 +62,6 @@ public class ContainerLifecycle implements ITestListener {
     public void onStart(final ITestContext iTestContext) {
         final String loggerName = "test-lifecycle";
 
-        if (!SystemInstance.isInitialized()) {
-            logger = Logger.getLogger(loggerName);
-            return;
-        }
-
         container = EJBContainer.createEJBContainer(new PropertiesBuilder()
             .p("openejb.jul.forceReload", Boolean.TRUE.toString())
             .p("openejb.log.color", Boolean.toString(!System.getProperty("os.name").toLowerCase().contains("win")))

http://git-wip-us.apache.org/repos/asf/incubator-batchee/blob/0a8765b4/tools/cli/src/main/java/org/apache/batchee/cli/command/JobOperatorCommand.java
----------------------------------------------------------------------
diff --git a/tools/cli/src/main/java/org/apache/batchee/cli/command/JobOperatorCommand.java b/tools/cli/src/main/java/org/apache/batchee/cli/command/JobOperatorCommand.java
index 001e4cb..a2165cb 100644
--- a/tools/cli/src/main/java/org/apache/batchee/cli/command/JobOperatorCommand.java
+++ b/tools/cli/src/main/java/org/apache/batchee/cli/command/JobOperatorCommand.java
@@ -200,7 +200,6 @@ public abstract class JobOperatorCommand implements Runnable {
         }
     }
 
-    // TODO: import URLClassLoaderFirst instead of URLClassLoader
     private ClassLoader createLoader(final ClassLoader parent) throws MalformedURLException {
         final Collection<URL> urls = new LinkedList<URL>();