Re: [PR] MINOR: Migrate EligibleLeaderReplicasIntegrationTestto use new test infra [kafka]

["jim0987795064 (via GitHub)" <gi...@apache.org>]

jim0987795064 commented on code in PR #20199:
URL: https://github.com/apache/kafka/pull/20199#discussion_r2229689255


##########
test-common/test-common-runtime/src/main/java/org/apache/kafka/common/test/ClusterInstance.java:
##########
@@ -444,6 +444,16 @@ default List<Integer> boundPorts() {
                 .map(KafkaBroker::socketServer)
                 .map(s -> s.boundPort(clientListener()))
                 .toList();
+    }
 
+    default void restartDeadBrokers() throws InterruptedException {
+        if (brokers().isEmpty()) {
+            throw new IllegalArgumentException("Must supply at least one server config.");
+        }
+        brokers().entrySet().forEach(entry -> {
+            if (!entry.getValue().isShutdown()) {

Review Comment:
   Thanks for the feedback. I've addressed issues mentioned above.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org