You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2016/12/22 22:46:19 UTC
svn commit: r1775760 -
/jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListener.java
Author: pmouawad
Date: Thu Dec 22 22:46:19 2016
New Revision: 1775760
URL: http://svn.apache.org/viewvc?rev=1775760&view=rev
Log:
Sonar : Fix errors and code smells
Modified:
jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListener.java
Modified: jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListener.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListener.java?rev=1775760&r1=1775759&r2=1775760&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListener.java (original)
+++ jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListener.java Thu Dec 22 22:46:19 2016
@@ -99,13 +99,7 @@ public class BackendListener extends Abs
public static final String DEFAULT_QUEUE_SIZE = "5000";
// Create unique object as marker for end of queue
- private transient static final SampleResult FINAL_SAMPLE_RESULT = new SampleResult();
-
- // Name of the test element. Set up by testStarted().
- private transient String myName;
-
- // Holds listenerClientData for this test element
- private transient ListenerClientData listenerClientData;
+ private static transient final SampleResult FINAL_SAMPLE_RESULT = new SampleResult();
/*
* This is needed for distributed testing where there is 1 instance
@@ -115,6 +109,12 @@ public class BackendListener extends Abs
private static final Map<String, ListenerClientData> queuesByTestElementName =
new ConcurrentHashMap<>();
+ // Name of the test element. Set up by testStarted().
+ private transient String myName;
+
+ // Holds listenerClientData for this test element
+ private transient ListenerClientData listenerClientData;
+
/**
* Create a BackendListener.
*/
@@ -244,7 +244,7 @@ public class BackendListener extends Abs
}
}
} catch (InterruptedException e) {
- // NOOP
+ Thread.currentThread().interrupt();
}
// We may have been interrupted
sendToListener(backendListenerClient, context, sampleResults);
@@ -265,7 +265,7 @@ public class BackendListener extends Abs
final BackendListenerClient backendListenerClient,
final BackendListenerContext context,
final List<SampleResult> sampleResults) {
- if (sampleResults.size() > 0) {
+ if (!sampleResults.isEmpty()) {
backendListenerClient.handleSampleResults(sampleResults, context);
sampleResults.clear();
}
@@ -357,12 +357,12 @@ public class BackendListener extends Abs
@Override
public void testEnded(String host) {
synchronized (LOCK) {
- ListenerClientData listenerClientData = queuesByTestElementName.get(myName);
+ ListenerClientData listenerClientDataForName = queuesByTestElementName.get(myName);
if(LOGGER.isDebugEnabled()) {
- LOGGER.debug("testEnded called on instance "+myName+"#"+listenerClientData.instanceCount);
+ LOGGER.debug("testEnded called on instance "+myName+"#"+listenerClientDataForName.instanceCount);
}
- listenerClientData.instanceCount--;
- if (listenerClientData.instanceCount > 0){
+ listenerClientDataForName.instanceCount--;
+ if (listenerClientDataForName.instanceCount > 0){
// Not the last instance of myName
return;
}