[GitHub] wicket issue #193: WICKET-6287 Switch from json.org to open-json - 8.x

[tdunning <gi...@git.apache.org>]

Github user tdunning commented on the issue:

    https://github.com/apache/wicket/pull/193
  
    Not sure why, but I see 1.2-SNAPSHOT in the comments coming through.
    
    That is going to point at open-json 1.3 when you actually move forward,
    right?
    
    (just call me "better safe than sorry")
    
    
    
    On Mon, Dec 5, 2016 at 9:13 PM, Andrea Del Bene <no...@github.com>
    wrote:
    
    > *@bitstorm* approved this pull request.
    >
    > Green light for me. I've also prepared a pr for Wicketstuff to work with
    > this new library:
    > wicketstuff/core#566 <https://github.com/wicketstuff/core/pull/566>
    > ------------------------------
    >
    > In pom.xml
    > <https://github.com/apache/wicket/pull/193#pullrequestreview-10368392>:
    >
    > > @@ -447,6 +447,12 @@
    >  				<type>jar</type>
    >  			</dependency>
    >  			<dependency>
    > +		    	<groupId>com.tdunning</groupId>
    > +		    	<artifactId>json</artifactId>
    > +				<version>1.2-SNAPSHOT</version>
    >
    > I've already opened an issue. Just in case...
    >
    > tdunning/open-json#2 <https://github.com/tdunning/open-json/issues/2>
    >
    > \u2014
    > You are receiving this because you commented.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/wicket/pull/193#pullrequestreview-10368392>,
    > or mute the thread
    > <https://github.com/notifications/unsubscribe-auth/AAPSeqjqTjPZGaOQmErVakoBjXmRza0Gks5rE__-gaJpZM4K74MM>
    > .
    >



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---