You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/16 01:58:31 UTC

[GitHub] [arrow-datafusion] xudong963 commented on a change in pull request #1812: Update documentation example for change in API

xudong963 commented on a change in pull request #1812:
URL: https://github.com/apache/arrow-datafusion/pull/1812#discussion_r807469469



##########
File path: docs/source/user-guide/example-usage.md
##########
@@ -28,18 +37,18 @@ use datafusion::prelude::*;
 async fn main() -> datafusion::error::Result<()> {
   // register the table
   let mut ctx = ExecutionContext::new();
-  ctx.register_csv("example", "tests/example.csv", CsvReadOptions::new())?;
+  ctx.register_csv("example", "tests/example.csv", CsvReadOptions::new()).await?;

Review comment:
       Amazing! unexpectedly, no `.await` before.

##########
File path: docs/source/user-guide/example-usage.md
##########
@@ -19,7 +19,16 @@
 
 # Example Usage
 
-Run a SQL query against data stored in a CSV:
+## Update `Cargo.toml`
+
+Add the following to your `Cargo.toml` file:
+
+```yaml

Review comment:
       In fact, we can directly use ```toml




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org