[GitHub] [spark] steveloughran commented on a diff in pull request #38980: [SPARK-41448] Make consistent MR job IDs in FileBatchWriter and FileFormatWriter

["steveloughran (via GitHub)" <gi...@apache.org>]

steveloughran commented on code in PR #38980:
URL: https://github.com/apache/spark/pull/38980#discussion_r1109921742


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/FileWriterFactory.scala:
##########
@@ -29,6 +29,9 @@ import org.apache.spark.sql.execution.datasources.{DynamicPartitionDataSingleWri
 case class FileWriterFactory (
     description: WriteJobDescription,
     committer: FileCommitProtocol) extends DataWriterFactory {
+
+  private val jobId = SparkHadoopWriterUtils.createJobID(new Date, 0)

Review Comment:
   it does implement WritableComparable; you could use WritableConverter to do the marshalling if you don't just want to do via a string



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org