You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by zhuganghuaonnet <gi...@git.apache.org> on 2017/08/14 04:59:02 UTC

[GitHub] flink pull request #4535: Eventhubs-support read from and write to Azure eve...

GitHub user zhuganghuaonnet opened a pull request:

    https://github.com/apache/flink/pull/4535

    Eventhubs-support read from and write to Azure eventhubs

    *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
    
    *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
    
    ## Contribution Checklist
    
      - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
      
      - Name the pull request in the form "[FLINK-1234] [component] Title of the pull request", where *FLINK-1234* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
      Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
    
      - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
      
      - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](http://flink.apache.org/contribute-code.html#best-practices).
    
      - Each pull request should address only one issue, not mix up code from multiple issues.
      
      - Each commit in the pull request has a meaningful commit message (including the JIRA id)
    
      - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
    
    
    **(The sections below can be removed for hotfixes of typos)**
    
    ## What is the purpose of the change
    
    *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)*
    
    
    ## Brief change log
    
    *(for example:)*
      - *The TaskInfo is stored in the blob store on job creation time as a persistent artifact*
      - *Deployments RPC transmits only the blob storage reference*
      - *TaskManagers retrieve the TaskInfo from the blob cache*
    
    
    ## Verifying this change
    
    *(Please pick either of the following options)*
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    *(or)*
    
    This change is already covered by existing tests, such as *(please describe tests)*.
    
    *(or)*
    
    This change added tests and can be verified as follows:
    
    *(example:)*
      - *Added integration tests for end-to-end deployment with large payloads (100MB)*
      - *Extended integration test for recovery after master (JobManager) failure*
      - *Added test that validates that TaskInfo is transferred only once across recoveries*
      - *Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes / no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
      - The serializers: (yes / no / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / no / don't know)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes / no)
      - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zhuganghuaonnet/flink eventhubs

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4535.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4535
    
----
commit fc868aacee07389c39d2e77faa99749dc27b73f5
Author: Joe Zhu <zh...@hotmail.com>
Date:   2017-06-15T08:27:52Z

    Add Azure eventhubs connector

commit cc1df1ea6d80e6ad3e4cd5189ca20f02fd1fd243
Author: Joe Zhu <zh...@hotmail.com>
Date:   2017-06-16T07:42:42Z

    [FLINK]Eventhub connector support timestamp and watermark

commit 9ffdd8b041509337235939b9a83cc476784440a7
Author: Joe Zhu <zh...@hotmail.com>
Date:   2017-06-22T10:07:27Z

    Add eventhub producer, and to examples for eventhub read and write

commit 896669805e62c71b27280a85a571eed66cca538d
Author: Joe Zhu <zh...@hotmail.com>
Date:   2017-06-26T03:57:29Z

    Fix retrive NM cores as -1 when NM core value is not set in yarn-site.xml

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4535: Eventhubs-support read from and write to Azure eventhubs

Posted by greghogan <gi...@git.apache.org>.

Github user greghogan commented on the issue:

    https://github.com/apache/flink/pull/4535
  
    @tzulitai this does sound like a good candidate for inclusion in Flink. Perhaps a separate `flink-connectors` repo would work better than Apache Bahir.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4535: Eventhubs-support read from and write to Azure eventhubs

Posted by greghogan <gi...@git.apache.org>.

Github user greghogan commented on the issue:

    https://github.com/apache/flink/pull/4535
  
    @zhuganghuaonnet we should also mention that new connectors are being contributed through the Flink release of [Apache Bahir](http://bahir.apache.org).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4535: Eventhubs-support read from and write to Azure eventhubs

Posted by tzulitai <gi...@git.apache.org>.

Github user tzulitai commented on the issue:

    https://github.com/apache/flink/pull/4535
  
    @greghogan yes, a separate `flink-connectors` idea has always been a possible approach in the community, but AFAIK we haven't fully committed to it yet. I can continue to shepherd this contribution to be merged to Flink, and move it to `flink-connectors` that eventually happens.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4535: [FLINK-7474] [ Streaming Connectors] AzureEventhubs-conne...

Posted by zhuganghuaonnet <gi...@git.apache.org>.

Github user zhuganghuaonnet commented on the issue:

    https://github.com/apache/flink/pull/4535
  
    @tzulitai Already done. I may need add unit test cases. Should I include unit test cases in this pull request or open another one?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4535: [FLINK-7474] [ Streaming Connectors] AzureEventhubs-conne...

Posted by yew1eb <gi...@git.apache.org>.

Github user yew1eb commented on the issue:

    https://github.com/apache/flink/pull/4535
  
    Hi @zhuganghuaonnet , you should drop others commits and squash your commits. 
    :beers:


---

[GitHub] flink issue #4535: Eventhubs-support read from and write to Azure eventhubs

Posted by tzulitai <gi...@git.apache.org>.

Github user tzulitai commented on the issue:

    https://github.com/apache/flink/pull/4535
  
    Hi @zhuganghuaonnet, thanks a lot for this contribution!
    However, taking a step back, is there a JIRA ticket for this contribution?
    If not, please make sure that one is opened for it first. Also, for bigger contributions like this, you should make sure that the pull request template is properly filled out to ease the effort for reviewers.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4535: Eventhubs-support read from and write to Azure eventhubs

Posted by tzulitai <gi...@git.apache.org>.

Github user tzulitai commented on the issue:

    https://github.com/apache/flink/pull/4535
  
    @zhuganghuaonnet please let me know when you've opened the JIRA, and rebased this pull request onto the latest `master`. Also please remember to rename the pull request title (you can take a look at the other pull request titles as reference) and fill out the pull request template as necessary :)
    
    Thanks a lot!



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4535: [FLINK-7474] [ Streaming Connectors] AzureEventhubs-conne...

Posted by tzulitai <gi...@git.apache.org>.

Github user tzulitai commented on the issue:

    https://github.com/apache/flink/pull/4535
  
    @zhuganghuaonnet it doesn't seem like the PR is correctly rebased. Ideally, you should rebase your development branch to the latest master, and the PR only contains for your changes, and not others.
    
    And yes, please include necessary unit tests / integration tests along with the PR!


---

[GitHub] flink issue #4535: Eventhubs-support read from and write to Azure eventhubs

Posted by zhuganghuaonnet <gi...@git.apache.org>.

Github user zhuganghuaonnet commented on the issue:

https://github.com/apache/flink/pull/4535

Hi Tai,

I cannot find JIRA related to Azure eventhubs. I will create one later, fill pull request template and send another pull request. Thx.

Regards

Joe

________________________________
From: Tzu-Li Tai <no...@github.com>
Sent: Monday, August 14, 2017 3:48:53 PM
To: apache/flink
Cc: zhuganghuaonnet; Mention
Subject: Re: [apache/flink] Eventhubs-support read from and write to Azure eventhubs (#4535)

Hi @zhuganghuaonnet<https://github.com/zhuganghuaonnet>, thanks a lot for this contribution!
However, taking a step back, is there a JIRA ticket for this contribution?
If not, please make sure that one is opened for it first. Also, for bigger contributions like this, you should make sure that the pull request template is properly filled out to ease the effort for reviewers.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://github.com/apache/flink/pull/4535#issuecomment-322122182>, or mute the thread<https://github.com/notifications/unsubscribe-auth/APWS44gqqy5hT02uGV1Mlb2gSdRRCBEYks5sX_vkgaJpZM4O18go>.

---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4535: Eventhubs-support read from and write to Azure eventhubs

Posted by tzulitai <gi...@git.apache.org>.

Github user tzulitai commented on the issue:

    https://github.com/apache/flink/pull/4535
  
    @zhuganghuaonnet please also rebase this pull request (there are conflicting classes) and change the pull request title.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4535: Eventhubs-support read from and write to Azure eventhubs

Posted by tzulitai <gi...@git.apache.org>.

Github user tzulitai commented on the issue:

    https://github.com/apache/flink/pull/4535
  
    @greghogan I don't think there's actually a consensus that all new connectors should strictly go to Apache Bahir. It still depends case by case, and brought to discussion in the mailing lists if necessary.
    
    We have a growing base of Azure users, and I think it would be nice to have better Azure support. Having a connector for their mainly used event source would be a nice addition, IMO. What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4535: Eventhubs-support read from and write to Azure eventhubs

Posted by zhuganghuaonnet <gi...@git.apache.org>.

Github user zhuganghuaonnet commented on the issue:

https://github.com/apache/flink/pull/4535

@Tzu-Li Tai<ma...@github.com> I have created a jira https://issues.apache.org/jira/browse/FLINK-7474. Pls help to review. Thx. :)

________________________________
From: Tzu-Li Tai <no...@github.com>
Sent: Wednesday, August 16, 2017 12:54:30 PM
To: apache/flink
Cc: zhuganghuaonnet; Mention
Subject: Re: [apache/flink] Eventhubs-support read from and write to Azure eventhubs (#4535)

@zhuganghuaonnet<https://github.com/zhuganghuaonnet> please let me know when you've opened the JIRA, and rebased this pull request onto the latest master. Also please remember to rename the pull request title (you can take a look at the other pull request titles as reference) and fill out the pull request template as necessary :)

Thanks a lot!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://github.com/apache/flink/pull/4535#issuecomment-322666087>, or mute the thread<https://github.com/notifications/unsubscribe-auth/APWS4zlTWZ9F_4zj2t7gk-Te135tJg7fks5sYnYGgaJpZM4O18go>.