You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/05 13:42:40 UTC
[GitHub] [flink] Myasuka opened a new pull request #10767: [hotfix][docs]
Align the documentation of checkpoint directory to the actual implementation
Myasuka opened a new pull request #10767: [hotfix][docs] Align the documentation of checkpoint directory to the actual implementation
URL: https://github.com/apache/flink/pull/10767
## What is the purpose of the change
Current documentation of checkpoint directory only describe the initial proposal in FLINK-8531. However, this is not the current real checkpoint directory with actual implementation. Correct this part of description to not confuse users.
## Brief change log
Correct the documentation of `checkpoints.md` and `checkpoints.zh.md`.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10767: [hotfix][docs] Align
the documentation of checkpoint directory to the actual implementation
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10767: [hotfix][docs] Align the documentation of checkpoint directory to the actual implementation
URL: https://github.com/apache/flink/pull/10767#issuecomment-570913818
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 06f58c28c6e670b4c6a59547ed589bdba5e2384f (Sun Jan 05 13:44:38 UTC 2020)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10767: [hotfix][docs]
Align the documentation of checkpoint directory to the actual implementation
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10767: [hotfix][docs] Align the documentation of checkpoint directory to the actual implementation
URL: https://github.com/apache/flink/pull/10767#issuecomment-570915749
<!--
Meta data
Hash:06f58c28c6e670b4c6a59547ed589bdba5e2384f Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143142689 TriggerType:PUSH TriggerID:06f58c28c6e670b4c6a59547ed589bdba5e2384f
Hash:06f58c28c6e670b4c6a59547ed589bdba5e2384f Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4100 TriggerType:PUSH TriggerID:06f58c28c6e670b4c6a59547ed589bdba5e2384f
-->
## CI report:
* 06f58c28c6e670b4c6a59547ed589bdba5e2384f Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143142689) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4100)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] Myasuka commented on issue #10767: [hotfix][docs] Align the
documentation of checkpoint directory to the actual implementation
Posted by GitBox <gi...@apache.org>.
Myasuka commented on issue #10767: [hotfix][docs] Align the documentation of checkpoint directory to the actual implementation
URL: https://github.com/apache/flink/pull/10767#issuecomment-570913764
@pnowojski , would you please take a look at this hot fix?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10767: [hotfix][docs]
Align the documentation of checkpoint directory to the actual implementation
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10767: [hotfix][docs] Align the documentation of checkpoint directory to the actual implementation
URL: https://github.com/apache/flink/pull/10767#issuecomment-570915749
<!--
Meta data
Hash:06f58c28c6e670b4c6a59547ed589bdba5e2384f Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143142689 TriggerType:PUSH TriggerID:06f58c28c6e670b4c6a59547ed589bdba5e2384f
Hash:06f58c28c6e670b4c6a59547ed589bdba5e2384f Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4100 TriggerType:PUSH TriggerID:06f58c28c6e670b4c6a59547ed589bdba5e2384f
-->
## CI report:
* 06f58c28c6e670b4c6a59547ed589bdba5e2384f Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143142689) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4100)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] Myasuka commented on issue #10767: [hotfix][docs] Align the
documentation of checkpoint directory to the actual implementation
Posted by GitBox <gi...@apache.org>.
Myasuka commented on issue #10767: [hotfix][docs] Align the documentation of checkpoint directory to the actual implementation
URL: https://github.com/apache/flink/pull/10767#issuecomment-571057386
The travis CI failed due to a known issue: [FLINK-14894](https://issues.apache.org/jira/browse/FLINK-14894)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10767: [hotfix][docs] Align
the documentation of checkpoint directory to the actual implementation
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10767: [hotfix][docs] Align the documentation of checkpoint directory to the actual implementation
URL: https://github.com/apache/flink/pull/10767#issuecomment-570915749
<!--
Meta data
Hash:06f58c28c6e670b4c6a59547ed589bdba5e2384f Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:06f58c28c6e670b4c6a59547ed589bdba5e2384f
-->
## CI report:
* 06f58c28c6e670b4c6a59547ed589bdba5e2384f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10767: [hotfix][docs]
Align the documentation of checkpoint directory to the actual implementation
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10767: [hotfix][docs] Align the documentation of checkpoint directory to the actual implementation
URL: https://github.com/apache/flink/pull/10767#issuecomment-570915749
<!--
Meta data
Hash:06f58c28c6e670b4c6a59547ed589bdba5e2384f Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143142689 TriggerType:PUSH TriggerID:06f58c28c6e670b4c6a59547ed589bdba5e2384f
Hash:06f58c28c6e670b4c6a59547ed589bdba5e2384f Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4100 TriggerType:PUSH TriggerID:06f58c28c6e670b4c6a59547ed589bdba5e2384f
-->
## CI report:
* 06f58c28c6e670b4c6a59547ed589bdba5e2384f Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143142689) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4100)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] pnowojski commented on issue #10767: [hotfix][docs] Align
the documentation of checkpoint directory to the actual implementation
Posted by GitBox <gi...@apache.org>.
pnowojski commented on issue #10767: [hotfix][docs] Align the documentation of checkpoint directory to the actual implementation
URL: https://github.com/apache/flink/pull/10767#issuecomment-571150771
Thanks for the fix. I also backported it to the release-1.10 branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] pnowojski merged pull request #10767: [hotfix][docs] Align
the documentation of checkpoint directory to the actual implementation
Posted by GitBox <gi...@apache.org>.
pnowojski merged pull request #10767: [hotfix][docs] Align the documentation of checkpoint directory to the actual implementation
URL: https://github.com/apache/flink/pull/10767
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services