You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "PurelyApplied (GitHub)" <gi...@apache.org> on 2018/12/10 21:15:07 UTC

[GitHub] [geode-examples] PurelyApplied opened pull request #74: GEODE-6175: Add Jigsaw modules example.

* Replace homemade 'run' task with 'application' plugin
* Create 'jigsaw' directory to contain any other similar examples.
* Copy <examples>/cq example to <examples>/jigsaw/

Co-authored-by: Patrick Rhomberg <pr...@pivotal.io>
Co-authored-by: Jacob Barrett <jb...@pivotal.io>

[ Full content available at: https://github.com/apache/geode-examples/pull/74 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-examples] karensmolermiller commented on issue #74: GEODE-6175: Add Jigsaw modules example.

Posted by "karensmolermiller (GitHub)" <gi...@apache.org>.
I think that the README files can be vastly improved.  As a first step, include a sentence describing jigsaw and its benefits. Then, include directions as to how to run the example (instead of a pointer to the other example).  Some prose that describes how the various build files need to change for jigsaw would be super helpful, as it reduces the need for the example's user to acquire a different example so that the user can do a diff to see what is different.

[ Full content available at: https://github.com/apache/geode-examples/pull/74 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org