You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@samza.apache.org by Aleksandar Pejakovic <a....@levi9.com> on 2015/10/19 09:05:42 UTC

Review Request 39433: SAMZA-795: Fix getMax() error in Shanpshot

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39433/
-----------------------------------------------------------

Review request for samza.


Repository: samza


Description
-------

Changed:
```
    this.size = values.size();
```
to:
```
    this.size = this.values.size();
```


Diffs
-----

  samza-api/src/main/java/org/apache/samza/metrics/Snapshot.java 4c7b525 

Diff: https://reviews.apache.org/r/39433/diff/


Testing
-------


Thanks,

Aleksandar Pejakovic

Re: Review Request 39433: SAMZA-795: Fix getMax() error in Shanpshot

Posted by Navina Ramesh <nr...@linkedin.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39433/#review103139
-----------------------------------------------------------

Ship it!


Ship It!

- Navina Ramesh


On Oct. 19, 2015, 7:05 a.m., Aleksandar Pejakovic wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39433/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2015, 7:05 a.m.)
> 
> 
> Review request for samza.
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> Changed:
> ```
>     this.size = values.size();
> ```
> to:
> ```
>     this.size = this.values.size();
> ```
> 
> 
> Diffs
> -----
> 
>   samza-api/src/main/java/org/apache/samza/metrics/Snapshot.java 4c7b525 
> 
> Diff: https://reviews.apache.org/r/39433/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleksandar Pejakovic
> 
>