You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2022/10/12 13:38:49 UTC
[GitHub] [storm] zhoumengyks opened a new pull request, #3497: fix(sec): upgrade org.fusesource.mqtt-client:mqtt-client to 1.15
zhoumengyks opened a new pull request, #3497:
URL: https://github.com/apache/storm/pull/3497
### What happened？
There are 1 security vulnerabilities found in org.fusesource.mqtt-client:mqtt-client 1.10
- [CVE-2019-0222](https://www.oscs1024.com/hd/CVE-2019-0222)
### What did I do？
Upgrade org.fusesource.mqtt-client:mqtt-client from 1.10 to 1.15 for vulnerability fix
### What did you expect to happen？
Ideally, no insecure libs should be used.
### The specification of the pull request
[PR Specification](https://www.oscs1024.com/docs/pr-specification/) from OSCS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] bipinprasad commented on a diff in pull request #3497: fix(sec): upgrade org.fusesource.mqtt-client:mqtt-client to 1.15
Posted by GitBox <gi...@apache.org>.
bipinprasad commented on code in PR #3497:
URL: https://github.com/apache/storm/pull/3497#discussion_r1061039904
##########
external/storm-mqtt/pom.xml:
##########
@@ -13,8 +14,7 @@
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
--->
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+--><project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
Review Comment:
Here as well: a new line after the end of the copyright comment - for consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] bipinprasad commented on a diff in pull request #3497: fix(sec): upgrade org.fusesource.mqtt-client:mqtt-client to 1.15
Posted by GitBox <gi...@apache.org>.
bipinprasad commented on code in PR #3497:
URL: https://github.com/apache/storm/pull/3497#discussion_r1061039453
##########
examples/storm-mqtt-examples/pom.xml:
##########
@@ -13,9 +14,7 @@
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
--->
-
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+--><project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
Review Comment:
Can you insert a new line after the comment end to be consistent with the other pom files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(sec): upgrade org.fusesource.mqtt-client:mqtt-client to 1.15 (storm)
Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 commented on PR #3497:
URL: https://github.com/apache/storm/pull/3497#issuecomment-1678554142
Included in https://github.com/apache/storm/pull/3463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] bipinprasad commented on a diff in pull request #3497: fix(sec): upgrade org.fusesource.mqtt-client:mqtt-client to 1.15
Posted by GitBox <gi...@apache.org>.
bipinprasad commented on code in PR #3497:
URL: https://github.com/apache/storm/pull/3497#discussion_r1061040175
##########
external/storm-mqtt/pom.xml:
##########
@@ -73,7 +73,7 @@
<dependency>
<groupId>org.fusesource.mqtt-client</groupId>
<artifactId>mqtt-client</artifactId>
- <version>1.10</version>
+ <version>1.15</version>
Review Comment:
Also Update the DEPENDENCY and LICENSE files so that the build will go to success.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(sec): upgrade org.fusesource.mqtt-client:mqtt-client to 1.15 (storm)
Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 closed pull request #3497: fix(sec): upgrade org.fusesource.mqtt-client:mqtt-client to 1.15
URL: https://github.com/apache/storm/pull/3497
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org