[GitHub] [iceberg] hililiwei commented on pull request #6394: Flink: Port Support read options in flink source to 1.14 & 1.16

[GitBox <gi...@apache.org>]

hililiwei commented on PR #6394:
URL: https://github.com/apache/iceberg/pull/6394#issuecomment-1345175587

   ```
   $ git diff --no-index  flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/ flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/
   diff --git a/flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/IcebergTableSink.java b/flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/IcebergTableSink.java
   index 541342619..1b9268569 100644
   --- a/flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/IcebergTableSink.java
   +++ b/flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/IcebergTableSink.java
   @@ -21,13 +21,17 @@ package org.apache.iceberg.flink;
    import java.util.List;
    import java.util.Map;
    import org.apache.flink.configuration.ReadableConfig;
   +import org.apache.flink.streaming.api.datastream.DataStream;
   +import org.apache.flink.streaming.api.datastream.DataStreamSink;
    import org.apache.flink.table.api.TableSchema;
    import org.apache.flink.table.api.constraints.UniqueConstraint;
    import org.apache.flink.table.connector.ChangelogMode;
   +import org.apache.flink.table.connector.ProviderContext;
    import org.apache.flink.table.connector.sink.DataStreamSinkProvider;
    import org.apache.flink.table.connector.sink.DynamicTableSink;
    import org.apache.flink.table.connector.sink.abilities.SupportsOverwrite;
    import org.apache.flink.table.connector.sink.abilities.SupportsPartitioning;
   +import org.apache.flink.table.data.RowData;
    import org.apache.flink.types.RowKind;
    import org.apache.flink.util.Preconditions;
    import org.apache.iceberg.flink.sink.FlinkSink;
   @@ -69,16 +73,20 @@ public class IcebergTableSink implements DynamicTableSink, SupportsPartitioning,
        List<String> equalityColumns =
            tableSchema.getPrimaryKey().map(UniqueConstraint::getColumns).orElseGet(ImmutableList::of);
   
   -    return (DataStreamSinkProvider)
   -        (providerContext, dataStream) ->
   -            FlinkSink.forRowData(dataStream)
   -                .tableLoader(tableLoader)
   -                .tableSchema(tableSchema)
   -                .equalityFieldColumns(equalityColumns)
   -                .overwrite(overwrite)
   -                .setAll(writeProps)
   -                .flinkConf(readableConfig)
   -                .append();
   +    return new DataStreamSinkProvider() {
   +      @Override
   +      public DataStreamSink<?> consumeDataStream(
   +          ProviderContext providerContext, DataStream<RowData> dataStream) {
   +        return FlinkSink.forRowData(dataStream)
   +            .tableLoader(tableLoader)
   +            .tableSchema(tableSchema)
   +            .equalityFieldColumns(equalityColumns)
   +            .overwrite(overwrite)
   +            .setAll(writeProps)
   +            .flinkConf(readableConfig)
   +            .append();
   +      }
   +    };
      }
   
      @Override
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org