[GitHub] [knox] pzampino commented on a change in pull request #205: KNOX-2134 - Add caching to ZookeeperRemoteAliasService

[GitBox <gi...@apache.org>]

pzampino commented on a change in pull request #205: KNOX-2134 - Add caching to ZookeeperRemoteAliasService
URL: https://github.com/apache/knox/pull/205#discussion_r349764017
 
 

 ##########
 File path: gateway-server/src/test/java/org/apache/knox/gateway/services/security/impl/ZookeeperRemoteAliasMonitorTest.java
 ##########
 @@ -234,13 +233,19 @@ public void testListener() throws Exception {
                 + ZookeeperRemoteAliasService.PATH_SEPARATOR + expectedAliasDev,
             zkAlias.encrypt(expectedPasswordDev).getBytes(StandardCharsets.UTF_8));
 
+    try {
+      Thread.sleep(1000);
 
 Review comment:
   It takes some time for the znode changes to propagate to the listener. Back when I had done the origin remote registry work, I had used much shorter delay intervals in the tests, but then the tests would intermittently fail. The delay in those tests was bumped to 1s, so I've done the same here, to avoid the same intermittent failures.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services