[GitHub] drill pull request #665: DRILL-5056: UserException does not write full messa...

[Ben-Zvi <gi...@git.apache.org>]

Github user Ben-Zvi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/665#discussion_r91155444
  
    --- Diff: common/src/main/java/org/apache/drill/common/exceptions/UserException.java ---
    @@ -37,6 +37,7 @@
      *
      * @see org.apache.drill.exec.proto.UserBitShared.DrillPBError.ErrorType
      */
    +@SuppressWarnings("serial")
    --- End diff --
    
    Should there instead be in this class :
         private static final long serialVersionUID = -3796081521525479249L;
    as does its super-class DrillRuntimeException, and as does its super-class RuntimeException, and as does its super-class Exception, and as does its super-class Throwable (which implements Serializable ........) ??
    (Not sure how to pick the specific UID number ...) 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---