[GitHub] [solr] epugh commented on a diff in pull request #1253: SOLR-10452: setQueryParams should be deprecated in favor of SolrClientBuilder methods

[GitBox <gi...@apache.org>]

epugh commented on code in PR #1253:
URL: https://github.com/apache/solr/pull/1253#discussion_r1058561116


##########
solr/core/src/java/org/apache/solr/update/UpdateShardHandler.java:
##########
@@ -138,19 +138,19 @@ public UpdateShardHandler(UpdateShardHandlerConfig cfg) {
         HttpClientUtil.createClient(
             clientParams, defaultConnectionManager, false, httpRequestExecutor);
 
+    Set<String> queryParams = new HashSet<>(2);
+    queryParams.add(DistributedUpdateProcessor.DISTRIB_FROM);
+    queryParams.add(DistributingUpdateProcessorFactory.DISTRIB_UPDATE_PARAM);

Review Comment:
   it can be!   I think there are a lot of places we could do that...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org