[jira] [Commented] (SUREFIRE-1811) Add resources to JPMS test module

["Pavel_K (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SUREFIRE-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149704#comment-17149704 ] 

Pavel_K commented on SUREFIRE-1811:
-----------------------------------

[~tibordigana] I have tried to find you in Skype using by your id "tibor.digana", however, when I enter it I see "Invite to Skype" or "Add funds" . Is this correct skype name?

By the way I've found finally solutions for unit tests and IT tests on module path. For unit test - I will use the /test/java/module-info.java, for example `open module theSameNameAsMain \{...}` + package names of the unit tests = package names of the module under test. For IT test I will create separate maven projects (using the same parent pom as normal modules of the project). What do you think about such approach?

> Add resources to JPMS test module
> ---------------------------------
>
>                 Key: SUREFIRE-1811
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1811
>             Project: Maven Surefire
>          Issue Type: New Feature
>          Components: Maven Failsafe Plugin
>    Affects Versions: 3.0.0-M5
>            Reporter: Pavel_K
>            Priority: Major
>
> I am testing version 3.0.0-M5 with two module-info in one project - one main and one for test. My test project is here https://github.com/PashaTurok/hibernate-h2-test4 . The problem is with resources. For example, I have  src/main/resources/META-INF/persistence.xml file that is not copied to test module. Because of this it is not possible to find resource in test module and it is necessary to use something like this https://github.com/PashaTurok/hibernate-h2-test4/blob/292e2e683ad72487cbf8d2e5a35dde0d9255001a/src/test/java/com/foo/hibernate/h2/test4/TestIT.java#L72 . 
> In target/test-classes/META-INF/jpms.args I see:
> {code:java}
> --patch-module
> my.project=/home/..../hibernate-h2-test4/src/main/java, /home/.../hibernate-h2-test4/target/generated-sources/annotations
> {code}
> As I understand test module will NOT contain resources from the module under test? I mean that test module will NOT contain /home/..../hibernate-h2-test4/src/main/resources? 
> That's why I suggest to include src/main/resources in test module.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)