You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/07 20:49:24 UTC

[GitHub] [beam] msbukal opened a new pull request, #17315: [BEAM-14280] FhirIO: use .search() or .searchType instead of .setResourceType()

msbukal opened a new pull request, #17315:
URL: https://github.com/apache/beam/pull/17315

   The .setResourceType(...) behaviour is unintended on the generated client library, and is potentially unstable.
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] asf-ci commented on pull request #17315: [BEAM-14280] FhirIO: use .search() or .searchType instead of .setResourceType()

Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17315:
URL: https://github.com/apache/beam/pull/17315#issuecomment-1092187922

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] asf-ci commented on pull request #17315: [BEAM-14280] FhirIO: use .search() or .searchType instead of .setResourceType()

Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17315:
URL: https://github.com/apache/beam/pull/17315#issuecomment-1092187926

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #17315: [BEAM-14280] FhirIO: use .search() or .searchType() instead of SearchResourceRequest.setResourceType()

Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #17315:
URL: https://github.com/apache/beam/pull/17315#issuecomment-1110226155

   ah so sorry about the delay


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] asf-ci commented on pull request #17315: [BEAM-14280] FhirIO: use .search() or .searchType instead of .setResourceType()

Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17315:
URL: https://github.com/apache/beam/pull/17315#issuecomment-1092187924

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] msbukal commented on pull request #17315: [BEAM-14280] FhirIO: use .search() or .searchType() instead of SearchResourceRequest.setResourceType()

Posted by GitBox <gi...@apache.org>.
msbukal commented on PR #17315:
URL: https://github.com/apache/beam/pull/17315#issuecomment-1092209720

   R: pabloem@


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] asf-ci commented on pull request #17315: [BEAM-14280] FhirIO: use .search() or .searchType instead of .setResourceType()

Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17315:
URL: https://github.com/apache/beam/pull/17315#issuecomment-1092187925

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] msbukal commented on pull request #17315: [BEAM-14280] FhirIO: use .search() or .searchType instead of .setResourceType()

Posted by GitBox <gi...@apache.org>.
msbukal commented on PR #17315:
URL: https://github.com/apache/beam/pull/17315#issuecomment-1092189137

   Run Java PreCommit
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] asf-ci commented on pull request #17315: [BEAM-14280] FhirIO: use .search() or .searchType instead of .setResourceType()

Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17315:
URL: https://github.com/apache/beam/pull/17315#issuecomment-1092187923

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem merged pull request #17315: [BEAM-14280] FhirIO: use .search() or .searchType() instead of SearchResourceRequest.setResourceType()

Posted by GitBox <gi...@apache.org>.
pabloem merged PR #17315:
URL: https://github.com/apache/beam/pull/17315


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] msbukal commented on pull request #17315: [BEAM-14280] FhirIO: use .search() or .searchType instead of .setResourceType()

Posted by GitBox <gi...@apache.org>.
msbukal commented on PR #17315:
URL: https://github.com/apache/beam/pull/17315#issuecomment-1092189385

   Run Java PostCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #17315: [BEAM-14280] FhirIO: use .search() or .searchType() instead of SearchResourceRequest.setResourceType()

Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #17315:
URL: https://github.com/apache/beam/pull/17315#issuecomment-1110227133

   LGTM!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org