You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/08/12 06:43:16 UTC

[GitHub] [incubator-dolphinscheduler] zhuangchong commented on issue #3471: [Improvement][common] JSONUtils.toMap It is not necessary to check whether the JSON method is empty again.

zhuangchong commented on issue #3471:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/3471#issuecomment-672642333


   1.JsonUitls.toMap (string JSON) the parameter values are checked for null both inside and outside the method, and the code is repeated.
   
   ---
   1. JsonUitls.toMap(String json) 针对参数值在方法内和方法外都进行校验空，进行了2遍校验，代码是重复的。


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org