You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Colm O hEigeartaigh <co...@apache.org> on 2017/06/28 11:15:34 UTC
Review Request 60499: SENTRY-1823 - Fix the sentryShell script to
support other types
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60499/
-----------------------------------------------------------
Review request for sentry.
Bugs: SENTRY-1823
https://issues.apache.org/jira/browse/SENTRY-1823
Repository: sentry
Description
-------
The sentryShell currently only works with Hive. This task is to get it to work with other types (Kafka/Solr).
Diffs
-----
bin/sentryShell d21a65f7
Diff: https://reviews.apache.org/r/60499/diff/1/
Testing
-------
Tested that it gets the correct privileges for Hive + Kafka.
Thanks,
Colm O hEigeartaigh
Re: Review Request 60499: SENTRY-1823 - Fix the sentryShell script to
support other types
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60499/#review179154
-----------------------------------------------------------
Ship it!
Ship It!
bin/sentryShell
Line 61 (original), 61 (patched)
<https://reviews.apache.org/r/60499/#comment253697>
That's a rather ugly way to achieve this. We can just convert everything to lower case with something like echo $2 | tr A-Z a-z or perhaps use some neat bash trick for that.
- Alexander Kolbasov
On June 28, 2017, 11:15 a.m., Colm O hEigeartaigh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60499/
> -----------------------------------------------------------
>
> (Updated June 28, 2017, 11:15 a.m.)
>
>
> Review request for sentry.
>
>
> Bugs: SENTRY-1823
> https://issues.apache.org/jira/browse/SENTRY-1823
>
>
> Repository: sentry
>
>
> Description
> -------
>
> The sentryShell currently only works with Hive. This task is to get it to work with other types (Kafka/Solr).
>
>
> Diffs
> -----
>
> bin/sentryShell d21a65f7
>
>
> Diff: https://reviews.apache.org/r/60499/diff/1/
>
>
> Testing
> -------
>
> Tested that it gets the correct privileges for Hive + Kafka.
>
>
> Thanks,
>
> Colm O hEigeartaigh
>
>
Re: Review Request 60499: SENTRY-1823 - Fix the sentryShell script to
support other types
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60499/#review179271
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Kolbasov
On June 29, 2017, 10:50 a.m., Colm O hEigeartaigh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60499/
> -----------------------------------------------------------
>
> (Updated June 29, 2017, 10:50 a.m.)
>
>
> Review request for sentry.
>
>
> Bugs: SENTRY-1823
> https://issues.apache.org/jira/browse/SENTRY-1823
>
>
> Repository: sentry
>
>
> Description
> -------
>
> The sentryShell currently only works with Hive. This task is to get it to work with other types (Kafka/Solr).
>
>
> Diffs
> -----
>
> bin/sentryShell d21a65f7
>
>
> Diff: https://reviews.apache.org/r/60499/diff/2/
>
>
> Testing
> -------
>
> Tested that it gets the correct privileges for Hive + Kafka.
>
>
> Thanks,
>
> Colm O hEigeartaigh
>
>
Re: Review Request 60499: SENTRY-1823 - Fix the sentryShell script to
support other types
Posted by Na Li <li...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60499/#review179283
-----------------------------------------------------------
Ship it!
Ship It!
- Na Li
On June 29, 2017, 10:50 a.m., Colm O hEigeartaigh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60499/
> -----------------------------------------------------------
>
> (Updated June 29, 2017, 10:50 a.m.)
>
>
> Review request for sentry.
>
>
> Bugs: SENTRY-1823
> https://issues.apache.org/jira/browse/SENTRY-1823
>
>
> Repository: sentry
>
>
> Description
> -------
>
> The sentryShell currently only works with Hive. This task is to get it to work with other types (Kafka/Solr).
>
>
> Diffs
> -----
>
> bin/sentryShell d21a65f7
>
>
> Diff: https://reviews.apache.org/r/60499/diff/2/
>
>
> Testing
> -------
>
> Tested that it gets the correct privileges for Hive + Kafka.
>
>
> Thanks,
>
> Colm O hEigeartaigh
>
>
Re: Review Request 60499: SENTRY-1823 - Fix the sentryShell script to
support other types
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60499/
-----------------------------------------------------------
(Updated June 29, 2017, 10:50 a.m.)
Review request for sentry.
Bugs: SENTRY-1823
https://issues.apache.org/jira/browse/SENTRY-1823
Repository: sentry
Description
-------
The sentryShell currently only works with Hive. This task is to get it to work with other types (Kafka/Solr).
Diffs (updated)
-----
bin/sentryShell d21a65f7
Diff: https://reviews.apache.org/r/60499/diff/2/
Changes: https://reviews.apache.org/r/60499/diff/1-2/
Testing
-------
Tested that it gets the correct privileges for Hive + Kafka.
Thanks,
Colm O hEigeartaigh
Re: Review Request 60499: SENTRY-1823 - Fix the sentryShell script to
support other types
Posted by Colm O hEigeartaigh <co...@apache.org>.
> On June 28, 2017, 7:20 p.m., Alexander Kolbasov wrote:
> > bin/sentryShell
> > Line 60 (original), 60 (patched)
> > <https://reviews.apache.org/r/60499/diff/1/?file=1766139#file1766139line60>
> >
> > Why not use getopt instead?
getopt does not support long options (--type) on OSX.
- Colm
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60499/#review179155
-----------------------------------------------------------
On June 29, 2017, 10:50 a.m., Colm O hEigeartaigh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60499/
> -----------------------------------------------------------
>
> (Updated June 29, 2017, 10:50 a.m.)
>
>
> Review request for sentry.
>
>
> Bugs: SENTRY-1823
> https://issues.apache.org/jira/browse/SENTRY-1823
>
>
> Repository: sentry
>
>
> Description
> -------
>
> The sentryShell currently only works with Hive. This task is to get it to work with other types (Kafka/Solr).
>
>
> Diffs
> -----
>
> bin/sentryShell d21a65f7
>
>
> Diff: https://reviews.apache.org/r/60499/diff/2/
>
>
> Testing
> -------
>
> Tested that it gets the correct privileges for Hive + Kafka.
>
>
> Thanks,
>
> Colm O hEigeartaigh
>
>
Re: Review Request 60499: SENTRY-1823 - Fix the sentryShell script to
support other types
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60499/#review179155
-----------------------------------------------------------
bin/sentryShell
Line 60 (original), 60 (patched)
<https://reviews.apache.org/r/60499/#comment253700>
Why not use getopt instead?
bin/sentryShell
Line 61 (original), 61 (patched)
<https://reviews.apache.org/r/60499/#comment253699>
Even better, we should just ignore the case, require lower case in command and use case statement.
- Alexander Kolbasov
On June 28, 2017, 11:15 a.m., Colm O hEigeartaigh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60499/
> -----------------------------------------------------------
>
> (Updated June 28, 2017, 11:15 a.m.)
>
>
> Review request for sentry.
>
>
> Bugs: SENTRY-1823
> https://issues.apache.org/jira/browse/SENTRY-1823
>
>
> Repository: sentry
>
>
> Description
> -------
>
> The sentryShell currently only works with Hive. This task is to get it to work with other types (Kafka/Solr).
>
>
> Diffs
> -----
>
> bin/sentryShell d21a65f7
>
>
> Diff: https://reviews.apache.org/r/60499/diff/1/
>
>
> Testing
> -------
>
> Tested that it gets the correct privileges for Hive + Kafka.
>
>
> Thanks,
>
> Colm O hEigeartaigh
>
>