You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by zh...@apache.org on 2026/06/06 04:33:22 UTC
(shardingsphere) branch master updated: Remove useless javadoc on @Override methods (#38819)
This is an automated email from the ASF dual-hosted git repository.
terrymanu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 6e3bb9f6e34 Remove useless javadoc on @Override methods (#38819)
6e3bb9f6e34 is described below
commit 6e3bb9f6e34e99a217eb32b7337d2f6080b4be68
Author: Liang Zhang <zh...@apache.org>
AuthorDate: Sat Jun 6 12:33:15 2026 +0800
Remove useless javadoc on @Override methods (#38819)
---
...hardingSphereDistributedTransactionManager.java | 3 -
.../xa/spi/XATransactionManagerProvider.java | 3 -
.../handler/execute/MCPSQLExecutionFacade.java | 6 -
.../service/EncryptWorkflowValidationService.java | 11 --
.../service/MaskWorkflowValidationService.java | 11 --
.../capability/MCPDatabaseCapabilityProvider.java | 17 ---
.../metadata/query/MetadataQueryService.java | 127 ---------------------
.../dml/item/ExpressionProjectionSegment.java | 5 -
8 files changed, 183 deletions(-)
diff --git a/kernel/transaction/api/src/main/java/org/apache/shardingsphere/transaction/spi/ShardingSphereDistributedTransactionManager.java b/kernel/transaction/api/src/main/java/org/apache/shardingsphere/transaction/spi/ShardingSphereDistributedTransactionManager.java
index 9d0cb2baead..54973843e20 100644
--- a/kernel/transaction/api/src/main/java/org/apache/shardingsphere/transaction/spi/ShardingSphereDistributedTransactionManager.java
+++ b/kernel/transaction/api/src/main/java/org/apache/shardingsphere/transaction/spi/ShardingSphereDistributedTransactionManager.java
@@ -97,9 +97,6 @@ public interface ShardingSphereDistributedTransactionManager extends TypedSPI, T
*/
boolean containsProviderType(String providerType);
- /**
- * Close transaction manager.
- */
@Override
void close();
}
diff --git a/kernel/transaction/type/xa/spi/src/main/java/org/apache/shardingsphere/transaction/xa/spi/XATransactionManagerProvider.java b/kernel/transaction/type/xa/spi/src/main/java/org/apache/shardingsphere/transaction/xa/spi/XATransactionManagerProvider.java
index e8b2d842fe6..79d8815f5d3 100644
--- a/kernel/transaction/type/xa/spi/src/main/java/org/apache/shardingsphere/transaction/xa/spi/XATransactionManagerProvider.java
+++ b/kernel/transaction/type/xa/spi/src/main/java/org/apache/shardingsphere/transaction/xa/spi/XATransactionManagerProvider.java
@@ -62,9 +62,6 @@ public interface XATransactionManagerProvider extends TypedSPI, AutoCloseable {
*/
TransactionManager getTransactionManager();
- /**
- * Close XA transaction manager provider.
- */
@Override
void close();
}
diff --git a/mcp/core/src/main/java/org/apache/shardingsphere/mcp/core/tool/handler/execute/MCPSQLExecutionFacade.java b/mcp/core/src/main/java/org/apache/shardingsphere/mcp/core/tool/handler/execute/MCPSQLExecutionFacade.java
index 06658001a3a..cec21566e01 100644
--- a/mcp/core/src/main/java/org/apache/shardingsphere/mcp/core/tool/handler/execute/MCPSQLExecutionFacade.java
+++ b/mcp/core/src/main/java/org/apache/shardingsphere/mcp/core/tool/handler/execute/MCPSQLExecutionFacade.java
@@ -74,12 +74,6 @@ public final class MCPSQLExecutionFacade implements MCPFeatureExecutionFacade {
this.sqlExecutionTraceFactory = sqlExecutionTraceFactory;
}
- /**
- * Execute one MCP SQL request.
- *
- * @param executionRequest SQL execution request
- * @return execution response
- */
@Override
public SQLExecutionResponse execute(final SQLExecutionRequest executionRequest) {
try {
diff --git a/mcp/features/encrypt/src/main/java/org/apache/shardingsphere/mcp/feature/encrypt/tool/service/EncryptWorkflowValidationService.java b/mcp/features/encrypt/src/main/java/org/apache/shardingsphere/mcp/feature/encrypt/tool/service/EncryptWorkflowValidationService.java
index 028de365620..c95d5d7ee75 100644
--- a/mcp/features/encrypt/src/main/java/org/apache/shardingsphere/mcp/feature/encrypt/tool/service/EncryptWorkflowValidationService.java
+++ b/mcp/features/encrypt/src/main/java/org/apache/shardingsphere/mcp/feature/encrypt/tool/service/EncryptWorkflowValidationService.java
@@ -50,17 +50,6 @@ public final class EncryptWorkflowValidationService implements MCPWorkflowRuntim
private final WorkflowSynchronizationSupport workflowSynchronizationSupport = new WorkflowSynchronizationSupport();
- /**
- * Validate workflow artifacts.
- *
- * @param workflowSessionContext workflow session context
- * @param metadataQueryFacade metadata query facade
- * @param queryFacade query facade
- * @param executionFacade execution facade
- * @param sessionId session id
- * @param snapshot workflow snapshot
- * @return validation payload
- */
@Override
public Map<String, Object> validate(final WorkflowSessionContext workflowSessionContext, final MCPMetadataQueryFacade metadataQueryFacade,
final MCPFeatureQueryFacade queryFacade, final MCPFeatureExecutionFacade executionFacade, final String sessionId,
diff --git a/mcp/features/mask/src/main/java/org/apache/shardingsphere/mcp/feature/mask/tool/service/MaskWorkflowValidationService.java b/mcp/features/mask/src/main/java/org/apache/shardingsphere/mcp/feature/mask/tool/service/MaskWorkflowValidationService.java
index 2517a18fb06..42ee515e07c 100644
--- a/mcp/features/mask/src/main/java/org/apache/shardingsphere/mcp/feature/mask/tool/service/MaskWorkflowValidationService.java
+++ b/mcp/features/mask/src/main/java/org/apache/shardingsphere/mcp/feature/mask/tool/service/MaskWorkflowValidationService.java
@@ -53,17 +53,6 @@ public final class MaskWorkflowValidationService implements MCPWorkflowRuntimeHa
workflowSynchronizationSupport = new WorkflowSynchronizationSupport();
}
- /**
- * Validate workflow artifacts.
- *
- * @param workflowSessionContext workflow session context
- * @param metadataQueryFacade metadata query facade
- * @param queryFacade query facade
- * @param executionFacade execution facade
- * @param sessionId session id
- * @param snapshot workflow snapshot
- * @return validation payload
- */
@Override
public Map<String, Object> validate(final WorkflowSessionContext workflowSessionContext, final MCPMetadataQueryFacade metadataQueryFacade,
final MCPFeatureQueryFacade queryFacade, final MCPFeatureExecutionFacade executionFacade, final String sessionId,
diff --git a/mcp/support/src/main/java/org/apache/shardingsphere/mcp/support/database/capability/MCPDatabaseCapabilityProvider.java b/mcp/support/src/main/java/org/apache/shardingsphere/mcp/support/database/capability/MCPDatabaseCapabilityProvider.java
index aee0b478863..95128a71462 100644
--- a/mcp/support/src/main/java/org/apache/shardingsphere/mcp/support/database/capability/MCPDatabaseCapabilityProvider.java
+++ b/mcp/support/src/main/java/org/apache/shardingsphere/mcp/support/database/capability/MCPDatabaseCapabilityProvider.java
@@ -43,33 +43,16 @@ public final class MCPDatabaseCapabilityProvider implements MCPFeatureCapability
databaseCapabilities = createDatabaseCapabilities(databaseProfiles);
}
- /**
- * Provide the database-level capability.
- *
- * @param databaseName database name
- * @return database-level capability
- */
@Override
public Optional<MCPDatabaseCapability> provide(final String databaseName) {
return Optional.ofNullable(databaseCapabilities.get(databaseName));
}
- /**
- * Find runtime database profile.
- *
- * @param databaseName database name
- * @return runtime database profile
- */
@Override
public Optional<RuntimeDatabaseProfile> findDatabaseProfile(final String databaseName) {
return Optional.ofNullable(databaseProfiles.get(databaseName));
}
- /**
- * Get runtime database profiles.
- *
- * @return runtime database profiles
- */
@Override
public List<RuntimeDatabaseProfile> getDatabaseProfiles() {
return new LinkedList<>(databaseProfiles.values());
diff --git a/mcp/support/src/main/java/org/apache/shardingsphere/mcp/support/database/metadata/query/MetadataQueryService.java b/mcp/support/src/main/java/org/apache/shardingsphere/mcp/support/database/metadata/query/MetadataQueryService.java
index 0d894bf882c..b98db3c36a2 100644
--- a/mcp/support/src/main/java/org/apache/shardingsphere/mcp/support/database/metadata/query/MetadataQueryService.java
+++ b/mcp/support/src/main/java/org/apache/shardingsphere/mcp/support/database/metadata/query/MetadataQueryService.java
@@ -51,34 +51,17 @@ public final class MetadataQueryService implements MCPMetadataQueryFacade {
private final RequestScopedMetadataContext metadataContext;
- /**
- * Query databases.
- *
- * @return database metadata
- */
@Override
public List<MCPDatabaseMetadata> queryDatabases() {
return databaseCapabilityProvider.getDatabaseProfiles().stream()
.map(this::createDatabaseSummary).sorted(Comparator.comparing(MCPDatabaseMetadata::getDatabase)).toList();
}
- /**
- * Query database.
- *
- * @param databaseName database name
- * @return database metadata
- */
@Override
public Optional<MCPDatabaseMetadata> queryDatabase(final String databaseName) {
return metadataContext.loadDatabaseMetadata(databaseName).map(MCPDatabaseMetadata::createDetail);
}
- /**
- * Query schemas.
- *
- * @param databaseName database name
- * @return schema metadata
- */
@Override
public List<MCPSchemaMetadata> querySchemas(final String databaseName) {
if (!isSupportedMetadataObjectType(databaseName, SupportedMCPMetadataObjectType.SCHEMA)) {
@@ -88,13 +71,6 @@ public final class MetadataQueryService implements MCPMetadataQueryFacade {
.map(MCPSchemaMetadata::createSummary).sorted(Comparator.comparing(MCPSchemaMetadata::getSchema)).toList()).orElse(Collections.emptyList());
}
- /**
- * Query schema.
- *
- * @param databaseName database name
- * @param schemaName schema name
- * @return schema metadata
- */
@Override
public Optional<MCPSchemaMetadata> querySchema(final String databaseName, final String schemaName) {
if (!isSupportedMetadataObjectType(databaseName, SupportedMCPMetadataObjectType.SCHEMA)) {
@@ -103,13 +79,6 @@ public final class MetadataQueryService implements MCPMetadataQueryFacade {
return findSchema(databaseName, schemaName).map(MCPSchemaMetadata::createDetail);
}
- /**
- * Query tables.
- *
- * @param databaseName database name
- * @param schemaName schema name
- * @return table metadata
- */
@Override
public List<MCPTableMetadata> queryTables(final String databaseName, final String schemaName) {
if (!isSupportedMetadataObjectType(databaseName, SupportedMCPMetadataObjectType.TABLE)) {
@@ -121,14 +90,6 @@ public final class MetadataQueryService implements MCPMetadataQueryFacade {
.toList()).orElse(Collections.emptyList());
}
- /**
- * Query table.
- *
- * @param databaseName database name
- * @param schemaName schema name
- * @param tableName table name
- * @return table metadata
- */
@Override
public Optional<MCPTableMetadata> queryTable(final String databaseName, final String schemaName, final String tableName) {
if (!isSupportedMetadataObjectType(databaseName, SupportedMCPMetadataObjectType.TABLE)) {
@@ -137,13 +98,6 @@ public final class MetadataQueryService implements MCPMetadataQueryFacade {
return findTable(databaseName, schemaName, tableName).map(MCPTableMetadata::createDetail);
}
- /**
- * Query views.
- *
- * @param databaseName database name
- * @param schemaName schema name
- * @return view metadata
- */
@Override
public List<MCPViewMetadata> queryViews(final String databaseName, final String schemaName) {
if (!isSupportedMetadataObjectType(databaseName, SupportedMCPMetadataObjectType.VIEW)) {
@@ -155,14 +109,6 @@ public final class MetadataQueryService implements MCPMetadataQueryFacade {
.toList()).orElse(Collections.emptyList());
}
- /**
- * Query view.
- *
- * @param databaseName database name
- * @param schemaName schema name
- * @param viewName view name
- * @return view metadata
- */
@Override
public Optional<MCPViewMetadata> queryView(final String databaseName, final String schemaName, final String viewName) {
if (!isSupportedMetadataObjectType(databaseName, SupportedMCPMetadataObjectType.VIEW)) {
@@ -171,14 +117,6 @@ public final class MetadataQueryService implements MCPMetadataQueryFacade {
return findView(databaseName, schemaName, viewName).map(MCPViewMetadata::createDetail);
}
- /**
- * Query table columns.
- *
- * @param databaseName database name
- * @param schemaName schema name
- * @param tableName table name
- * @return column metadata
- */
@Override
public List<MCPColumnMetadata> queryTableColumns(final String databaseName, final String schemaName, final String tableName) {
if (!isSupportedMetadataObjectType(databaseName, SupportedMCPMetadataObjectType.COLUMN)) {
@@ -193,15 +131,6 @@ public final class MetadataQueryService implements MCPMetadataQueryFacade {
return result;
}
- /**
- * Query table column.
- *
- * @param databaseName database name
- * @param schemaName schema name
- * @param tableName table name
- * @param columnName column name
- * @return column metadata
- */
@Override
public Optional<MCPColumnMetadata> queryTableColumn(final String databaseName, final String schemaName, final String tableName, final String columnName) {
if (!isSupportedMetadataObjectType(databaseName, SupportedMCPMetadataObjectType.COLUMN)) {
@@ -210,14 +139,6 @@ public final class MetadataQueryService implements MCPMetadataQueryFacade {
return findColumn(queryTableColumns(databaseName, schemaName, tableName), columnName);
}
- /**
- * Query view columns.
- *
- * @param databaseName database name
- * @param schemaName schema name
- * @param viewName view name
- * @return column metadata
- */
@Override
public List<MCPColumnMetadata> queryViewColumns(final String databaseName, final String schemaName, final String viewName) {
if (!isSupportedMetadataObjectType(databaseName, SupportedMCPMetadataObjectType.COLUMN)) {
@@ -226,15 +147,6 @@ public final class MetadataQueryService implements MCPMetadataQueryFacade {
return findView(databaseName, schemaName, viewName).map(optional -> sortColumns(optional.getColumns())).orElse(Collections.emptyList());
}
- /**
- * Query view column.
- *
- * @param databaseName database name
- * @param schemaName schema name
- * @param viewName view name
- * @param columnName column name
- * @return column metadata
- */
@Override
public Optional<MCPColumnMetadata> queryViewColumn(final String databaseName, final String schemaName, final String viewName, final String columnName) {
if (!isSupportedMetadataObjectType(databaseName, SupportedMCPMetadataObjectType.COLUMN)) {
@@ -243,14 +155,6 @@ public final class MetadataQueryService implements MCPMetadataQueryFacade {
return findColumn(queryViewColumns(databaseName, schemaName, viewName), columnName);
}
- /**
- * Query indexes.
- *
- * @param databaseName database name
- * @param schemaName schema name
- * @param tableName table name
- * @return index metadata
- */
@Override
public List<MCPIndexMetadata> queryIndexes(final String databaseName, final String schemaName, final String tableName) {
ShardingSpherePreconditions.checkState(isSupportedMetadataObjectType(databaseName, SupportedMCPMetadataObjectType.INDEX),
@@ -264,15 +168,6 @@ public final class MetadataQueryService implements MCPMetadataQueryFacade {
return result;
}
- /**
- * Query index.
- *
- * @param databaseName database name
- * @param schemaName schema name
- * @param tableName table name
- * @param indexName index name
- * @return index metadata
- */
@Override
public Optional<MCPIndexMetadata> queryIndex(final String databaseName, final String schemaName, final String tableName, final String indexName) {
ShardingSpherePreconditions.checkState(isSupportedMetadataObjectType(databaseName, SupportedMCPMetadataObjectType.INDEX),
@@ -280,13 +175,6 @@ public final class MetadataQueryService implements MCPMetadataQueryFacade {
return findIndex(queryIndexes(databaseName, schemaName, tableName), indexName);
}
- /**
- * Query sequences.
- *
- * @param databaseName database name
- * @param schemaName schema name
- * @return sequence metadata
- */
@Override
public List<MCPSequenceMetadata> querySequences(final String databaseName, final String schemaName) {
ShardingSpherePreconditions.checkState(isSupportedMetadataObjectType(databaseName, SupportedMCPMetadataObjectType.SEQUENCE),
@@ -300,14 +188,6 @@ public final class MetadataQueryService implements MCPMetadataQueryFacade {
return result;
}
- /**
- * Query sequence.
- *
- * @param databaseName database name
- * @param schemaName schema name
- * @param sequenceName sequence name
- * @return sequence metadata
- */
@Override
public Optional<MCPSequenceMetadata> querySequence(final String databaseName, final String schemaName, final String sequenceName) {
ShardingSpherePreconditions.checkState(isSupportedMetadataObjectType(databaseName, SupportedMCPMetadataObjectType.SEQUENCE),
@@ -340,13 +220,6 @@ public final class MetadataQueryService implements MCPMetadataQueryFacade {
return sequences.stream().filter(each -> sequenceName.equals(each.getSequence())).findFirst();
}
- /**
- * Judge whether the metadata object type is supported for the database.
- *
- * @param databaseName database name
- * @param objectType metadata object type
- * @return supported or not
- */
@Override
public boolean isSupportedMetadataObjectType(final String databaseName, final SupportedMCPMetadataObjectType objectType) {
Optional<MCPDatabaseCapability> databaseCapability = databaseCapabilityProvider.provide(databaseName);
diff --git a/parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/segment/dml/item/ExpressionProjectionSegment.java b/parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/segment/dml/item/ExpressionProjectionSegment.java
index 61f9d911aae..6e29d33a9ff 100644
--- a/parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/segment/dml/item/ExpressionProjectionSegment.java
+++ b/parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/segment/dml/item/ExpressionProjectionSegment.java
@@ -74,11 +74,6 @@ public final class ExpressionProjectionSegment implements ProjectionSegment, Com
return Optional.ofNullable(alias).map(AliasSegment::getIdentifier);
}
- /**
- * Get alias segment.
- *
- * @return alias segment
- */
@Override
public Optional<AliasSegment> getAliasSegment() {
return Optional.ofNullable(alias);