[GitHub] [tomcat] markt-asf commented on pull request #298: Fix BZ 64514 - classes missing from bootstrap.jar

[GitBox <gi...@apache.org>]

markt-asf commented on pull request #298:
URL: https://github.com/apache/tomcat/pull/298#issuecomment-642679912


   I don't think this is correct. Only those classes required during the bootstrap process need to be in the bootstrap JAR. If this was not correct, I'd expect to see reports of ClassNotFoundException on Tomcat start and there aren't any.
   
   Those classes may well have additional dependencies that are not used during the bootstrap process. Those dependencies do not belong in bootstrap.jar.
   
   Taking ExceptionUtils as an example, there is an explicit workaround in Bootstrap to account for that class not being accessible.
   
   For Globals, most (all?) of those will be constants which will be compiled into the class meaning there should be no runtime dependency on Globals.
   
   And so on.
   
   Unless you can provide a configuration that triggers a ClassNotFoundException on Tomcat start, I'm minded to resolve this as invalid.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org