[jira] Commented: (THRIFT-252) Python libraries unable to build with MSVC on Windows

["Adam Smith (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13003651#comment-13003651 ] 

Adam Smith commented on THRIFT-252:
-----------------------------------

I had to make a few tweaks to apply this patch to Thrift 0.6.0 on Windows 7 x64 with UAC turned off.  I compiled with mingw32, and I wouldn't call myself a Python/C++ expert so I'm not sure exactly why I had to do what I had to do.  Basically the #ifdef _MSC_VER wasn't working for me so I just hardcoded out the #ifdefs to switch into Windows mode, and I had to remove all of the #define's for INT*'s and the four typedef's for __int*'s from the diff.

Hope this helps somebody!  Cheers!

> Python libraries unable to build with MSVC on Windows
> -----------------------------------------------------
>
>                 Key: THRIFT-252
>                 URL: https://issues.apache.org/jira/browse/THRIFT-252
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Python - Library
>         Environment: Windows XP or Vista, Visual C++ 2008 (and likely others)
>            Reporter: Michael Greene
>            Assignee: Michael Greene
>         Attachments: thrift-252-python-msvc-1.diff, thrift-python-msvc-2.diff, thrift-python-msvc-memset.diff, thrift-python-msvc.diff
>
>
> This patch adds support for Visual C++ on Windows to the Python libraries.  stdbool and stdint are not available on MSVC, so alternates were defined.  netinet is replaced with winsock2.
> Additionally, setup.py is updated to support this platform and with the latest project information.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira