You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tephra.apache.org by anew <gi...@git.apache.org> on 2018/05/01 18:58:09 UTC

[GitHub] incubator-tephra pull request #72: TEPHRA-270 TEPHRA-271 Transaction state c...

Github user anew commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/72#discussion_r185303754
  
    --- Diff: tephra-core/src/main/java/org/apache/tephra/coprocessor/TransactionStateCache.java ---
    @@ -78,6 +78,7 @@ protected void startUp() throws Exception {
       protected void shutDown() throws Exception {
         if (refreshService != null) {
           refreshService.interrupt();
    +      refreshService.join(1000);
    --- End diff --
    
    I was mistaken, thinking that it would throw if the timeout is exceeded. Anyway, in a shutdown sequence we should catch all exceptions and ensure to continue the shutdown. 


---