You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by StephanEwen <gi...@git.apache.org> on 2018/02/19 09:55:57 UTC

[GitHub] flink pull request #5523: [FLINK-8695] [rocksdb] Move flink-statebackend-roc...

GitHub user StephanEwen opened a pull request:

    https://github.com/apache/flink/pull/5523

    [FLINK-8695] [rocksdb] Move flink-statebackend-rocksdb from 'flink-contrib' to 'flink-state-backends'.

    ## What is the purpose of the change
    
    This moves the `flink-statebackend-rocksdb` maven project out of `flink-contrib` and into a newly created folder `flink-state-backends`.
    
    The reason is that `flink-contrib` was meant to be a proving ground for new code with no guarantee of long-term maintenance, and the RocksDB state backend is (for a while already) a crucial and thoroughly maintained component.
    
    The change is otherwise trivial, the backend has still the same Maven Artifact ID, so there should be no compatibility issues.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/StephanEwen/incubator-flink rocks_move

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5523.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5523
    
----
commit dfb44444b2fd879b71ceba2c20ed774ffd709b8d
Author: Stephan Ewen <se...@...>
Date:   2018-02-19T09:31:44Z

    [FLINK-8695] [rocksdb] Move flink-statebackend-rocksdb from 'flink-contrib' to 'flink-state-backends'.

----


---

[GitHub] flink issue #5523: [FLINK-8695] [rocksdb] Move flink-statebackend-rocksdb fr...

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/5523
  
    Please modify travis_mvn_watchdog and update the rocksdb entry:
    ```
    MODULES_CORE="\
    flink-test-utils-parent/flink-test-utils,\
    flink-contrib/flink-statebackend-rocksdb,\
    flink-clients,\
    flink-core,\
    flink-java,\
    flink-optimizer,\
    flink-runtime,\
    flink-runtime-web,\
    flink-scala,\
    flink-scala-shell,\
    flink-streaming-java,\
    flink-streaming-scala"
    ```


---

[GitHub] flink pull request #5523: [FLINK-8695] [rocksdb] Move flink-statebackend-roc...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5523


---

[GitHub] flink issue #5523: [FLINK-8695] [rocksdb] Move flink-statebackend-rocksdb fr...

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/5523
  
    otherwise this looks good to me.


---

[GitHub] flink issue #5523: [FLINK-8695] [rocksdb] Move flink-statebackend-rocksdb fr...

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/5523
  
    Ah, that is the failure I was trying to debug, thanks!


---