You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/26 11:04:23 UTC

[GitHub] [flink] zentol commented on a change in pull request #18395: [FLINK-25685][rest] RestClusterClient supports uploading local file path with scheme

zentol commented on a change in pull request #18395:
URL: https://github.com/apache/flink/pull/18395#discussion_r792526438



##########
File path: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
##########
@@ -357,7 +357,8 @@ public void close() {
                                                         artifactFilePath.getName()));
                                         filesToUpload.add(
                                                 new FileUpload(
-                                                        Paths.get(artifacts.getValue().filePath),
+                                                        Paths.get(
+                                                                artifactFilePath.toUri().getPath()),

Review comment:
       ```suggestion
                                                                   artifactFilePath.toUri()),
   ```
   This seems redundant given that we do `Paths.get`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org