[jira] [Commented] (MSHADE-434) Strange side-effect on rat-plugin

["Slawomir Jaranowski (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MSHADE-434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17638396#comment-17638396 ] 

Slawomir Jaranowski commented on MSHADE-434:
--------------------------------------------

After some of tests:

Old version 3.1.1

{code}
[DEBUG] Configuring mojo 'org.apache.rat:apache-rat-plugin:0.13:check' with basic configurator -->
...
[DEBUG]   (f) basedir = /Users/slawomir.jaranowski/repos/temp/flink
[DEBUG]   (f) project = MavenProject: org.apache.flink:flink-parent:1.17-SNAPSHOT @ /Users/slawomir.jaranowski/repos/temp/flink/pom.xml
...
{code}
 
New version:

{code}
DEBUG] Configuring mojo 'org.apache.rat:apache-rat-plugin:0.13:check' with basic configurator -->
...
[DEBUG]   (f) basedir = /Users/slawomir.jaranowski/repos/temp/flink/target
[DEBUG]   (f) project = MavenProject: org.apache.flink:flink-parent:1.17-SNAPSHOT @ /Users/slawomir.jaranowski/repos/temp/flink/target/dependency-reduced-pom.xml
...
{code}

Looks like new reduced pom is now used as project pom ... 

Flink build looks a little complicated.

Why you check licenses by RAT at the one of last phase - {{verify}}.
Change phase of RAT to standard {{validate}} will help you.

> Strange side-effect on rat-plugin
> ---------------------------------
>
>                 Key: MSHADE-434
>                 URL: https://issues.apache.org/jira/browse/MSHADE-434
>             Project: Maven Shade Plugin
>          Issue Type: Bug
>    Affects Versions: 3.3.0
>            Reporter: Chesnay Schepler
>            Priority: Major
>
> When upgrading the shade-plugin from 3.2.4 to 3.3.0, without changing anything else, the Apache Flink builds are getting failed by the rat-plugin, complaining about a number of files in the root target/ directory.
> These files do exist, but are usually excluded by the plugin.
> For some reason upgrading the shade-plugin is changing this behavior.
> {code:java}
> [WARNING] Files with unapproved licenses:
>   /home/chesnay/dev/repos/flink/flink/target/rat.txt
>   /home/chesnay/dev/repos/flink/flink/target/checkstyle-result.xml
>   /home/chesnay/dev/repos/flink/flink/target/checkstyle-cachefile
> {code}
> This is reeeeally strange, and were wondering if you guys have any ideas for what could going on here.
> Interestingly enough explicitly listing these files (e.g., {{**/rat.txt}}) results in them being excluded again.
> This happened with Java 8 + Maven 3.2.5 and Java 11 + Maven 3.8.6 and is 100% reproducible.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)