You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/08/18 03:54:10 UTC
[GitHub] [apisix] monkeyDluffy6017 opened a new pull request, #7728: change: recovery old pb state after pubsub.new
monkeyDluffy6017 opened a new pull request, #7728:
URL: https://github.com/apache/apisix/pull/7728
### Description
recovery old pb state after pubsub.new, so that it won't affect other module who use pb state.
### Checklist
- [x] I have explained the need for this PR and the problem it solves
- [x] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [x] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a diff in pull request #7728: fix: recovery old pb state after pubsub.new
Posted by GitBox <gi...@apache.org>.
spacewander commented on code in PR #7728:
URL: https://github.com/apache/apisix/pull/7728#discussion_r948680559
##########
apisix/core/pubsub.lua:
##########
@@ -49,7 +49,7 @@ local function init_pb_state()
return "failed to load pubsub protocol: " .. err
Review Comment:
Maybe we need to apply the same fix in https://github.com/apache/apisix/pull/7639#discussion_r948679096 too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #7728: fix: recovery old pb state after pubsub.new
Posted by GitBox <gi...@apache.org>.
monkeyDluffy6017 commented on code in PR #7728:
URL: https://github.com/apache/apisix/pull/7728#discussion_r948688059
##########
apisix/core/pubsub.lua:
##########
@@ -49,7 +49,7 @@ local function init_pb_state()
return "failed to load pubsub protocol: " .. err
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #7728: fix: recovery old pb state after pubsub.new
Posted by GitBox <gi...@apache.org>.
spacewander merged PR #7728:
URL: https://github.com/apache/apisix/pull/7728
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org