[GitHub] [flink] TisonKun commented on a change in pull request #10104: [FLINK-14629][client] Refactor ScalaShellRemote(Stream)Environment to simplify inheritance

[GitBox <gi...@apache.org>]

TisonKun commented on a change in pull request #10104: [FLINK-14629][client] Refactor ScalaShellRemote(Stream)Environment to simplify inheritance
URL: https://github.com/apache/flink/pull/10104#discussion_r343005964
 
 

 ##########
 File path: flink-clients/src/main/java/org/apache/flink/client/ClientUtils.java
 ##########
 @@ -56,52 +56,6 @@
 
 	private static final Logger LOG = LoggerFactory.getLogger(ClientUtils.class);
 
-	/**
-	 * Adds the given jar files to the {@link JobGraph} via {@link JobGraph#addJar}. This will
-	 * throw an exception if a jar URL is not valid.
-	 */
-	public static void addJarFiles(JobGraph jobGraph, List<URL> jarFilesToAttach) {
-		for (URL jar : jarFilesToAttach) {
-			try {
-				jobGraph.addJar(new Path(jar.toURI()));
-			} catch (URISyntaxException e) {
-				throw new RuntimeException("URL is invalid. This should not happen.", e);
-			}
-		}
-	}
-
-	public static void checkJarFile(URL jar) throws IOException {
 
 Review comment:
   These methods moved mainly for `RemoteEnvironment` access `checkJarFile`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services