You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "kiaradlf (via GitHub)" <gi...@apache.org> on 2024/07/03 11:02:33 UTC
[I] switch HttpHook from using requests library to httpx? [airflow]
kiaradlf opened a new issue, #40580:
URL: https://github.com/apache/airflow/issues/40580
### Description
the [`HttpHook`](https://github.com/apache/airflow/blob/main/airflow/providers/http/hooks/http.py) currently uses the [`requests`](https://requests.readthedocs.io/) library for HTTP calls.
[`httpx`](https://www.python-httpx.org/) appears a more modern alternative, boasting support for e.g. http2, async support, and type annotations.
it would be nice if the http hook could perhaps take advantage of these as well.
### Use case/motivation
my own immediate use-case was password-protected client certificates, which seem not supported in `requests`.
### Related issues
_No response_
### Are you willing to submit a PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] switch HttpHook from using requests library to httpx? [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #40580:
URL: https://github.com/apache/airflow/issues/40580#issuecomment-2205886736
I am not sure we recently switched back from httpx to requests in file task handler, because it did not work with some specific NO_PROXY settings https://github.com/apache/airflow/pull/39799. And since HTTPHook is just simple wrapper and has simple fuynctionality - we do not need all the "fancy" features `httpx` has. But if someone (like you) take on the task to make sure to handle the issues like the one in #39799 - then why not - with documentation etc.
We need someone to take a lead, analyse all pros and cons and things supported/not supported by both and come up with good documentation.
Would you like to take a lead on that one ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] switch HttpHook from using requests library to httpx? [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #40580:
URL: https://github.com/apache/airflow/issues/40580#issuecomment-2234848451
This issue has been automatically marked as stale because it has been open for 14 days with no response from the author. It will be closed in next 7 days if no further activity occurs from the issue author.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] switch HttpHook from using requests library to httpx? [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #40580:
URL: https://github.com/apache/airflow/issues/40580#issuecomment-2249098038
This issue has been closed because it has not received response from the issue author.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] switch HttpHook from using requests library to httpx? [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #40580: switch HttpHook from using requests library to httpx?
URL: https://github.com/apache/airflow/issues/40580
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org