You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/27 12:18:49 UTC

[GitHub] [flink] zentol opened a new pull request #14777: [FLINK-21164][rest] Delete temporary jars

zentol opened a new pull request #14777:
URL: https://github.com/apache/flink/pull/14777


   Modifies the Jar(Run|Plan)Handler to call `PackagedProgram#deleteExtractedLibraries` once we are done with the job submission / plan generation.
   
   This is not **covered** by tests; I don't see a good way to do that since from the outside it is neither obvious which files are supposed to (not) exist nor where the temporary files would be located (by virtue of PackagedProgram not respecting the `io.tmp.dirs` option).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] zentol closed pull request #14777: [FLINK-21164][rest] Delete temporary jars

Posted by GitBox <gi...@apache.org>.
zentol closed pull request #14777:
URL: https://github.com/apache/flink/pull/14777


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #14777: [FLINK-21164][rest] Delete temporary jars

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14777:
URL: https://github.com/apache/flink/pull/14777#issuecomment-768249538


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 8eded2f333e80f7d9ef5adaada7a3323774b8869 (Wed Jan 27 12:21:35 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14777: [FLINK-21164][rest] Delete temporary jars

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14777:
URL: https://github.com/apache/flink/pull/14777#issuecomment-768256830


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8eded2f333e80f7d9ef5adaada7a3323774b8869",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12556",
       "triggerID" : "8eded2f333e80f7d9ef5adaada7a3323774b8869",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8eded2f333e80f7d9ef5adaada7a3323774b8869 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12556) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] zentol commented on a change in pull request #14777: [FLINK-21164][rest] Delete temporary jars

Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #14777:
URL: https://github.com/apache/flink/pull/14777#discussion_r566821745



##########
File path: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarRunHandler.java
##########
@@ -103,6 +103,11 @@ public JarRunHandler(
                         executor)
                 .handle(
                         (jobIds, throwable) -> {
+                            try {
+                                program.deleteExtractedLibraries();

Review comment:
       Yes, the JarListHandler has the same problem. I did not know it actually creates a `PackagedProgram`.
   
   As for the `ApplicationClusterEntryPoint`, the files _should_ be cleaned up when the entry point shuts down because we call `File#deleteOnExit` in `PackagedProgram#createTempFile`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14777: [FLINK-21164][rest] Delete temporary jars

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14777:
URL: https://github.com/apache/flink/pull/14777#issuecomment-768256830


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8eded2f333e80f7d9ef5adaada7a3323774b8869",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12556",
       "triggerID" : "8eded2f333e80f7d9ef5adaada7a3323774b8869",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce3c983720499212e587319cd6fdef3ccc6b97b5",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ce3c983720499212e587319cd6fdef3ccc6b97b5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c833d995b48a47ca6a8af7ae7c5eae5fd9d2c7ba",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12659",
       "triggerID" : "c833d995b48a47ca6a8af7ae7c5eae5fd9d2c7ba",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8eded2f333e80f7d9ef5adaada7a3323774b8869 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12556) 
   * ce3c983720499212e587319cd6fdef3ccc6b97b5 UNKNOWN
   * c833d995b48a47ca6a8af7ae7c5eae5fd9d2c7ba Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12659) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #14777: [FLINK-21164][rest] Delete temporary jars

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14777:
URL: https://github.com/apache/flink/pull/14777#issuecomment-768256830


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8eded2f333e80f7d9ef5adaada7a3323774b8869",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "8eded2f333e80f7d9ef5adaada7a3323774b8869",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8eded2f333e80f7d9ef5adaada7a3323774b8869 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14777: [FLINK-21164][rest] Delete temporary jars

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14777:
URL: https://github.com/apache/flink/pull/14777#issuecomment-768256830


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8eded2f333e80f7d9ef5adaada7a3323774b8869",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12556",
       "triggerID" : "8eded2f333e80f7d9ef5adaada7a3323774b8869",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce3c983720499212e587319cd6fdef3ccc6b97b5",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ce3c983720499212e587319cd6fdef3ccc6b97b5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c833d995b48a47ca6a8af7ae7c5eae5fd9d2c7ba",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c833d995b48a47ca6a8af7ae7c5eae5fd9d2c7ba",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8eded2f333e80f7d9ef5adaada7a3323774b8869 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12556) 
   * ce3c983720499212e587319cd6fdef3ccc6b97b5 UNKNOWN
   * c833d995b48a47ca6a8af7ae7c5eae5fd9d2c7ba UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] tillrohrmann commented on a change in pull request #14777: [FLINK-21164][rest] Delete temporary jars

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #14777:
URL: https://github.com/apache/flink/pull/14777#discussion_r566981325



##########
File path: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarRunHandler.java
##########
@@ -103,6 +103,11 @@ public JarRunHandler(
                         executor)
                 .handle(
                         (jobIds, throwable) -> {
+                            try {
+                                program.deleteExtractedLibraries();

Review comment:
       Alrighty. Thanks for the update.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] zentol commented on a change in pull request #14777: [FLINK-21164][rest] Delete temporary jars

Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #14777:
URL: https://github.com/apache/flink/pull/14777#discussion_r566823679



##########
File path: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarRunHandler.java
##########
@@ -103,6 +103,11 @@ public JarRunHandler(
                         executor)
                 .handle(
                         (jobIds, throwable) -> {
+                            try {
+                                program.deleteExtractedLibraries();

Review comment:
       Now whether they are actually deleted depends a bit on when the JVM executes the delete calls. If the ClassLoader is still around at that time, then the deletion may in fact fail.
   
   Explicitly closing the ClassLoader in the PackagedProgram (which unfortunately leaks into the JobGraph...) is a separate issue (see FLINK-9844).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14777: [FLINK-21164][rest] Delete temporary jars

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14777:
URL: https://github.com/apache/flink/pull/14777#issuecomment-768256830


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8eded2f333e80f7d9ef5adaada7a3323774b8869",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12556",
       "triggerID" : "8eded2f333e80f7d9ef5adaada7a3323774b8869",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce3c983720499212e587319cd6fdef3ccc6b97b5",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ce3c983720499212e587319cd6fdef3ccc6b97b5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c833d995b48a47ca6a8af7ae7c5eae5fd9d2c7ba",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12659",
       "triggerID" : "c833d995b48a47ca6a8af7ae7c5eae5fd9d2c7ba",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ce3c983720499212e587319cd6fdef3ccc6b97b5 UNKNOWN
   * c833d995b48a47ca6a8af7ae7c5eae5fd9d2c7ba Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12659) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] zentol commented on pull request #14777: [FLINK-21164][rest] Delete temporary jars

Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #14777:
URL: https://github.com/apache/flink/pull/14777#issuecomment-769820821


   @tillrohrmann I updated the PR. `PackagedProgram` now implements `AutoClosable`, and all usages of `PackagedProgram#deleteExtractedLibraries` have been migrated to use `close()` instead.
   In FLINK-9844 we can then extend this method to also close the ClassLoader.
   
   I will also file a follow-up ticket to explicitly call close() in the entry points.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14777: [FLINK-21164][rest] Delete temporary jars

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14777:
URL: https://github.com/apache/flink/pull/14777#issuecomment-768256830


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8eded2f333e80f7d9ef5adaada7a3323774b8869",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12556",
       "triggerID" : "8eded2f333e80f7d9ef5adaada7a3323774b8869",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8eded2f333e80f7d9ef5adaada7a3323774b8869 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12556) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] zentol merged pull request #14777: [FLINK-21164][rest] Delete temporary jars

Posted by GitBox <gi...@apache.org>.
zentol merged pull request #14777:
URL: https://github.com/apache/flink/pull/14777


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14777: [FLINK-21164][rest] Delete temporary jars

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14777:
URL: https://github.com/apache/flink/pull/14777#issuecomment-768249538


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit c833d995b48a47ca6a8af7ae7c5eae5fd9d2c7ba (Fri May 28 08:15:03 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14777: [FLINK-21164][rest] Delete temporary jars

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14777:
URL: https://github.com/apache/flink/pull/14777#issuecomment-768256830


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8eded2f333e80f7d9ef5adaada7a3323774b8869",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12556",
       "triggerID" : "8eded2f333e80f7d9ef5adaada7a3323774b8869",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce3c983720499212e587319cd6fdef3ccc6b97b5",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ce3c983720499212e587319cd6fdef3ccc6b97b5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8eded2f333e80f7d9ef5adaada7a3323774b8869 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12556) 
   * ce3c983720499212e587319cd6fdef3ccc6b97b5 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] tillrohrmann commented on a change in pull request #14777: [FLINK-21164][rest] Delete temporary jars

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #14777:
URL: https://github.com/apache/flink/pull/14777#discussion_r566799528



##########
File path: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarRunHandler.java
##########
@@ -103,6 +103,11 @@ public JarRunHandler(
                         executor)
                 .handle(
                         (jobIds, throwable) -> {
+                            try {
+                                program.deleteExtractedLibraries();
+                            } catch (Exception e) {
+                                log.debug("Error while deleting jars extracted from user-jar.");

Review comment:
       ```suggestion
                                   log.debug("Error while deleting jars extracted from user-jar.", e);
   ```

##########
File path: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarPlanHandler.java
##########
@@ -100,8 +101,19 @@ public JarPlanHandler(
 
         return CompletableFuture.supplyAsync(
                 () -> {
-                    final JobGraph jobGraph = context.toJobGraph(configuration, true);
-                    return planGenerator.apply(jobGraph);
+                    final PackagedProgram packagedProgram =
+                            context.toPackagedProgram(configuration);
+                    try {
+                        final JobGraph jobGraph =
+                                context.toJobGraph(packagedProgram, configuration, true);
+                        return planGenerator.apply(jobGraph);
+                    } finally {
+                        try {
+                            packagedProgram.deleteExtractedLibraries();
+                        } catch (Exception e) {
+                            log.debug("Error while deleting jars extracted from user-jar.");

Review comment:
       ```suggestion
                               log.debug("Error while deleting jars extracted from user-jar.", e);
   ```

##########
File path: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarRunHandler.java
##########
@@ -103,6 +103,11 @@ public JarRunHandler(
                         executor)
                 .handle(
                         (jobIds, throwable) -> {
+                            try {
+                                program.deleteExtractedLibraries();

Review comment:
       Isn't `JarListHandler` also susceptible to the problem?

##########
File path: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarRunHandler.java
##########
@@ -103,6 +103,11 @@ public JarRunHandler(
                         executor)
                 .handle(
                         (jobIds, throwable) -> {
+                            try {
+                                program.deleteExtractedLibraries();

Review comment:
       I am also wondering whether the `ApplicationClusterEntryPoint` really cleans up a `PackagedProgram` after using. Maybe this is something to investigate as a follow up.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org