You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/08/13 00:40:48 UTC
[GitHub] [trafficserver] maskit opened a new pull request #7110: Add QUIC draft-29 support
maskit opened a new pull request #7110:
URL: https://github.com/apache/trafficserver/pull/7110
About 3 months ago I said draft-29 would be available on 9.1.0, but we haven't had any RC for 9.0 yet so we may want to add draft-29 support to 9.0.
Supporting only draft-27 on 9.0 would make less sense in a few months because the latest is draft-29 and it's a kind of LTS version. Clients would drop draft-27 support and have draft-29 and above in near future.
Our draft-29 support has not been tested as much as draft-27 support in terms of interop, but it would probably be worth to take the small risk rather than completely losing compatible clients.
This PR literally adds draft-29 support, so both 27 and 29 would be supported. And it's an important change because it enables ATS to support 29 plus a later (or the final) version in the future.
Squashed commit of the following:
commit 4d579f49a21ca5ab5389d2edd3d225883c69743a
Author: Masakazu Kitajo <ma...@apache.org>
Date: Thu Aug 13 08:32:58 2020 +0900
Fix docs
commit 8c114c0eeb1096859228f6272a214d92d41f3c73
Merge: f39e3977f b52746404
Author: Masakazu Kitajo <ma...@apache.org>
Date: Thu Aug 13 07:31:56 2020 +0900
Merge branch 'master' into quic-latest
* master:
Adding autopep8 as a pre-commit hook. (#7071)
Refresh proxy protocol diagram (#7095)
Skip docs builds if there are no changes in the doc dir and files it includes (#7088)
Remove more deadcode (#7098)
destroy threads after job done (#7083)
Fix compilation error - missing '&' operator (#7093)
Adds description for ssl_ticket_number in ssl_multicert docs (#7091)
Ran clang-tidy over the source tree (#7077)
Move the direct self loop check later to HttpSM::do_http_server_open just before connection upstream. (#7069)
commit f39e3977f05b1432c93d427f3f516e1d2febe423
Merge: d09a75792 2219cee51
Author: Masakazu Kitajo <ma...@apache.org>
Date: Thu Aug 6 09:08:46 2020 +0900
Merge branch 'master' into quic-latest
* master:
Signal WRITE_COMPLETE regardless of transmission progress (#7062)
Converts files to #pragma once (#7089)
Fix eval_ip compile - missing const. (#7087)
Fix a crash on connection migration to the advertised preferred address (#7080)
Update and run the autopep8 make target (#7070)
Fixes no_content_length status code description in docs (#7086)
const-ify quic/http3 code (#7084)
Fixes build warnings in maxmind_acl (#7085)
Add TS_USE_QUIC to traffic_layout info (#7074)
Added support for out of tree builds with vscode (#7072)
constify Print() methods and other low hanging fruit (#7068)
Updating to AuTest 1.8.1. (#7065)
Use system include-style for STL and OpenSSL headers (#7066)
tests: gitignore ssl-delay-server binary (#7067)
Conflicts:
iocore/net/quic/QUICLossDetector.cc
iocore/net/quic/QUICLossDetector.h
commit d09a757926f28b0af5a6be89b09f4e965e0ee963
Author: Randall Meyer <rr...@apache.org>
Date: Tue Aug 4 13:52:53 2020 -0700
const-ify quic/http3 code (#7079)
commit 84e4c8eb0b6d2e410b85c8c0eece2ffe83f8068b
Merge: 50937c097 3087f1642
Author: Masakazu Kitajo <ma...@apache.org>
Date: Fri Jul 31 10:24:13 2020 +0900
Merge branch 'master' into quic-latest
* master:
Fix a crash on active timeout on QUIC connections (#7059)
Don't make an error on receiving retransmitted handshake data (#7061)
Document proxy.config.http.cache.post_method. (#7060)
Quote out lists of servers and domains in splitdns.config example (#7057)
Fix proxy.process.http.current_client_connections (#7056)
Fixed CLIENT-URL to use the pristine client URL (#7050)
Removes FIXME that is unlikely to be fixed at this point in the project history (#7058)
Move to denylists and allowlists (#7034)
Avoid unnecessary copying of STL map for QUICTPConfigQCP class. (#7039)
commit 50937c0976476f4f643181ab882e7e5ab7b5e7bd
Merge: f6e174414 9467a2c1c
Author: Masakazu Kitajo <ma...@apache.org>
Date: Tue Jul 28 10:08:26 2020 +0900
Merge branch 'master' into quic-latest
* master:
Fixes spelling/license formatting in traffic_dump plugin (#7047)
Fixes spelling in docs (#7048)
Fixes spelling H3-related code (#7046)
Cleans up various versions checks (#7049)
Fix a typo (#7043)
Conflicts:
iocore/net/quic/QUICHandshake.cc
iocore/net/quic/QUICLossDetector.cc
iocore/net/quic/QUICNewRenoCongestionController.cc
iocore/net/quic/test/test_QUICPacketFactory.cc
commit f6e17441438c9161a15ff913630363bdcc62ae85
Merge: 83e1da7ec 549c62605
Author: Masakazu Kitajo <ma...@apache.org>
Date: Mon Jul 27 11:11:58 2020 +0900
Merge branch 'master' into quic-latest
* master:
Make tls_conn_timeout test more reliable in CI (#7018)
Remove deprecated verify.server for 9.0 (#7040)
Updated GitHub description and homepage URL to be https (#7019)
Add virtual destructor to QUICTPConfig. (#7036)
Fix code to eliminate warning and enable feature (#7031)
add a null check to avoid crashing (#7035)
Squashed commit of the following: (#7000)
Fixed problem with all "forced" volumes cache (#7028)
Spacing tweaks to acl_filter_rule::print (#7026)
Removes dead code from iocore/dns (#7025)
Removes TODO (#7027)
Add logic to resolve content-length transfer-encoding conflicts on response (#6992)
Add memory_profile plugin (#7014)
Fix typos relating to tls_bridge (#7011)
slice: clean up of created 502 response header (#6919)
Add new API / TSPluginDSOReloadEnable that overrides the configuration variable `proxy.config.plugin.dynamic_reload_mode` for a particular plugin. (#6880)
Remove incorrect assert in inactivity timeout handling (#7012)
Removes use of SPLIT_DNS macro (#7010)
Fixed core when sending back a redirect and having an invalid server response (#7004)
slice: fix throttle not work (#7008)
Updates to thread scale factor (#7007)
Added tasks and launch files for vscode, to configure, build and debug (#7005)
NextHop Strategy Refactor and Fixes (#6782)
Make the setting of the continuation handler safer. (#6996)
ProtocolStack n -> count (#7006)
Fix volume/stripe calcs when using forced volumes (#6995)
Cleanup: Write error message on diags output instead of stderr (#6997)
Conflicts:
iocore/net/P_QUICNetVConnection.h
iocore/net/P_QUICPacketHandler.h
iocore/net/QUICNetProcessor.cc
iocore/net/QUICNetVConnection.cc
iocore/net/QUICPacketHandler.cc
iocore/net/quic/Mock.h
iocore/net/quic/QUICCongestionController.h
iocore/net/quic/QUICContext.cc
iocore/net/quic/QUICContext.h
iocore/net/quic/QUICDebugNames.cc
iocore/net/quic/QUICFrame.cc
iocore/net/quic/QUICHandshake.cc
iocore/net/quic/QUICKeyGenerator.h
iocore/net/quic/QUICLossDetector.cc
iocore/net/quic/QUICLossDetector.h
iocore/net/quic/QUICNewRenoCongestionController.cc
iocore/net/quic/QUICPacket.cc
iocore/net/quic/QUICPacket.h
iocore/net/quic/QUICPacketFactory.cc
iocore/net/quic/QUICPacketFactory.h
iocore/net/quic/QUICRetryIntegrityTag.cc
iocore/net/quic/QUICRetryIntegrityTag.h
iocore/net/quic/QUICTLS.h
iocore/net/quic/QUICTLS_boringssl.cc
iocore/net/quic/QUICTLS_openssl.cc
iocore/net/quic/QUICTransportParameters.cc
iocore/net/quic/QUICTransportParameters.h
iocore/net/quic/QUICTypes.cc
iocore/net/quic/QUICTypes.h
iocore/net/quic/qlog/QLogListener.h
iocore/net/quic/test/test_QUICHandshakeProtocol.cc
iocore/net/quic/test/test_QUICLossDetector.cc
iocore/net/quic/test/test_QUICPacket.cc
iocore/net/quic/test/test_QUICPacketFactory.cc
iocore/net/quic/test/test_QUICPacketHeaderProtector.cc
iocore/net/quic/test/test_QUICStreamManager.cc
iocore/net/quic/test/test_QUICVersionNegotiator.cc
proxy/http/HttpProxyServerMain.cc
src/traffic_quic/quic_client.cc
src/tscore/ink_inet.cc
commit 83e1da7ecca7979d6fbfe498804363e478733941
Author: Masakazu Kitajo <ma...@apache.org>
Date: Wed Jul 22 23:26:56 2020 +0900
Fix a crash on path validation
commit c74bd89603739bb4f3ac07e462293c4f96f65506
Author: Masakazu Kitajo <ma...@apache.org>
Date: Wed Jul 22 23:19:05 2020 +0900
Fix a crash on traffic_quic
commit b4a0c8cdb6762c38831135c702f975cdf0836db7
Author: Masakazu Kitajo <ma...@apache.org>
Date: Wed Jul 22 16:37:02 2020 +0900
Update Congestion Control logic to draft-29
commit 53da24017791e12f3a5c400f2c5058645e336b0d
Author: Masakazu Kitajo <ma...@apache.org>
Date: Wed Jul 22 11:40:18 2020 +0900
Adjust debug log verbosity
commit 92a34b0186535292408ba40b1db0eac3069bfa2a
Author: Masakazu Kitajo <ma...@apache.org>
Date: Tue Jul 21 12:04:00 2020 +0900
Fix infinite PING
commit 42c4054b9280618ba5d8a6b90b5eb16aa194003a
Author: Masakazu Kitajo <ma...@apache.org>
Date: Thu Jul 9 10:16:04 2020 +0900
Update Loss Detection logic to draft-29
commit e8109c0ba6bd643d9efd11acf617e4234dd784df
Author: Masakazu Kitajo <ma...@apache.org>
Date: Fri Jun 26 10:57:42 2020 +0900
Update tests
commit 3a8cb4ac985a3745e565a3824c37d2b437af2abe
Author: Masakazu Kitajo <ma...@apache.org>
Date: Thu Jun 25 14:58:47 2020 +0900
Use different keys and nonces for Draft-27 and Draft-29
commit 37af6254f67633c59a46770b78d599195647b657
Author: Masakazu Kitajo <ma...@apache.org>
Date: Thu Jun 25 14:14:57 2020 +0900
Use different salts for Draft-27 and Draft-29
commit 52e57fe283308dcb3979a900c06f2afe02f97314
Author: Masakazu Kitajo <ma...@apache.org>
Date: Mon Jun 22 11:53:43 2020 +0900
Rename SERVER_BUSY to CONNECTION_REFUSED
commit e5fb638c56005e4a0f9951b8518280a7f7df18c5
Author: Masakazu Kitajo <ma...@apache.org>
Date: Mon Jun 22 11:50:38 2020 +0900
Update QUIC draft version numbers to 29
commit a9ef9b0a4142e5d37d1d0736e8dce1faed0c39e1
Author: Masakazu Kitajo <ma...@apache.org>
Date: Fri Jul 10 17:21:46 2020 +0900
Update code for BoringSSL
commit 58cac989ffbbf9e9422a1ecb88ec761821399794
Author: Masakazu Kitajo <ma...@apache.org>
Date: Thu Jun 4 11:24:16 2020 +0900
Don't include exercise version number provided by a client into VN packet
commit 47e1eb749119dcbc409435153fc473152200df4d
Author: Masakazu Kitajo <ma...@apache.org>
Date: Thu Jun 4 10:45:14 2020 +0900
Updates tests and fixes a couple of typoes
commit f41ca7b22221fa4d8319de8b97c17337e1fcc1c3
Author: Masakazu Kitajo <ma...@apache.org>
Date: Mon Jun 1 12:46:32 2020 +0900
Support both QUIC draft-27 and draft-28
commit 3a5b3c70331078c3701d33e91c2e0414aa689cdd
Author: Masakazu Kitajo <ma...@apache.org>
Date: Thu May 28 13:57:57 2020 +0900
Add QUIC APPLICATION_ERROR error code
commit 0457e747a86b4a80ccc0acd017d21a581cb5ca3b
Author: Masakazu Kitajo <ma...@apache.org>
Date: Thu May 28 13:33:02 2020 +0900
Add support for new Transport Parameters on draft-28
commit 2717ecc632a613f4808b24765d302d5c5bc8d100
Author: Masakazu Kitajo <ma...@apache.org>
Date: Mon May 25 11:46:49 2020 +0900
Rename QUIC Transport Parameters
ORIGINAL_CONNECTION_ID -> ORIGINAL_DESTINATION_CONNECTION_ID
MAX_PACKET_SIZE -> MAX_UDP_PAYLOAD_SIZE
commit 9ef2167e32aab96dbd89cf304d74ee0121cdb601
Author: Masakazu Kitajo <ma...@apache.org>
Date: Mon May 25 10:34:54 2020 +0900
Update QUIC draft version numbers to 28
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on pull request #7110: Add QUIC draft-29 support
Posted by GitBox <gi...@apache.org>.
maskit commented on pull request #7110:
URL: https://github.com/apache/trafficserver/pull/7110#issuecomment-673296202
[approve ci docs]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #7110: Add QUIC draft-29 support
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #7110:
URL: https://github.com/apache/trafficserver/pull/7110#issuecomment-673849129
Cherry-picked to v9.0.x branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop merged pull request #7110: Add QUIC draft-29 support
Posted by GitBox <gi...@apache.org>.
zwoop merged pull request #7110:
URL: https://github.com/apache/trafficserver/pull/7110
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org