[jira] Commented: (ZOOKEEPER-127) Use of non-standard election ports in config breaks services

["Mahadev konar (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631182#action_12631182 ] 

Mahadev konar commented on ZOOKEEPER-127:
-----------------------------------------

just reviewd the code here are my comments -- 

1) why is the server id Long and not Integer?

2) we have two ways of specifying the quorum list now -- one is quorumserver arraylist and the other is the hashcode list -- can we combine these two and just keep the hash aary? Do we require these two to be different?

3) I do not see nay changes to QuorumPeerMain class? Shouldnt this be changed now to create a new contructor for QuorumPeer with the hashmap?




> Use of non-standard election ports in config breaks services
> ------------------------------------------------------------
>
>                 Key: ZOOKEEPER-127
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-127
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: quorum
>    Affects Versions: 3.0.0
>            Reporter: Mark Harwood
>            Assignee: Flavio Paiva Junqueira
>            Priority: Minor
>             Fix For: 3.0.0
>
>         Attachments: mhPortChanges.patch, ZOOKEEPER-127.patch
>
>
> In QuorumCnxManager.toSend there is a call to create a connection as follows:
>     channel = SocketChannel.open(new InetSocketAddress(addr, port));
> Unfortunately "addr" is the ip address of a remote server while "port" is the electionPort of *this* server.
> As an example, given this configuration (taken from my zoo.cfg)
>   server.1=10.20.9.254:2881
>   server.2=10.20.9.9:2882
>   server.3=10.20.9.254:2883
> Server 3 was observed trying to make a connection to host 10.20.9.9 on port 2883 and obviously failing.
> In tests where all machines use the same electionPort this bug would not manifest itself.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.