[GitHub] [ozone] xBis7 commented on a diff in pull request #4134: HDDS-7513. [Snapshot] Support list snapshots using fs -ls

["xBis7 (via GitHub)" <gi...@apache.org>]

xBis7 commented on code in PR #4134:
URL: https://github.com/apache/ozone/pull/4134#discussion_r1085311631


##########
hadoop-ozone/dist/src/main/smoketest/snapshot/fs-snapshot.robot:
##########
@@ -0,0 +1,96 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more

Review Comment:
   We are testing different operations but we could have a common setup robot file and reuse that. Isn't it cleaner to have different tests for `sh` commands and `fs` commands?
   
   #4171 is simpler and more straight forward. We could merge it and then refactor it in this PR and create a common setup robot file for setting up volumes, buckets, snapshots and reuse these keywords in both acceptance tests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org