You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by st...@apache.org on 2013/11/08 00:06:39 UTC

[3/5] js commit: CB-5253 remove webworks.exec

CB-5253 remove webworks.exec


Project: http://git-wip-us.apache.org/repos/asf/cordova-js/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-js/commit/09585fba
Tree: http://git-wip-us.apache.org/repos/asf/cordova-js/tree/09585fba
Diff: http://git-wip-us.apache.org/repos/asf/cordova-js/diff/09585fba

Branch: refs/heads/3.2.x
Commit: 09585fbade43445b66e5f7c8191bdf37c7b0ba0e
Parents: 30812d8
Author: Bryan Higgins <br...@bryanhiggins.net>
Authored: Sat Nov 2 23:59:39 2013 -0400
Committer: Steven Gill <st...@gmail.com>
Committed: Thu Nov 7 15:05:28 2013 -0800

----------------------------------------------------------------------
 lib/blackberry10/exec.js     | 72 ++++++++++++++++++++++++++++++++-
 lib/blackberry10/platform.js | 85 +++------------------------------------
 2 files changed, 77 insertions(+), 80 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-js/blob/09585fba/lib/blackberry10/exec.js
----------------------------------------------------------------------
diff --git a/lib/blackberry10/exec.js b/lib/blackberry10/exec.js
index f0ffd6f..138aa64 100644
--- a/lib/blackberry10/exec.js
+++ b/lib/blackberry10/exec.js
@@ -19,4 +19,74 @@
  *
 */
 
-module.exports = webworks.exec;
+var cordova = require('cordova');
+
+function RemoteFunctionCall(functionUri) {
+    var params = {};
+
+    function composeUri() {
+        return "http://localhost:8472/" + functionUri;
+    }
+
+    function createXhrRequest(uri, isAsync) {
+        var request = new XMLHttpRequest();
+        request.open("POST", uri, isAsync);
+        request.setRequestHeader("Content-Type", "application/json");
+        return request;
+    }
+
+    this.addParam = function (name, value) {
+        params[name] = encodeURIComponent(JSON.stringify(value));
+    };
+
+    this.makeSyncCall = function (success, error) {
+        var requestUri = composeUri(),
+        request = createXhrRequest(requestUri, false),
+        response;
+        request.send(JSON.stringify(params));
+        response = JSON.parse(decodeURIComponent(request.responseText) || "null");
+        return response;
+    };
+
+}
+
+module.exports = function (success, fail, service, action, args) {
+    var uri = service + "/" + action,
+    request = new RemoteFunctionCall(uri),
+    callbackId = service + cordova.callbackId++,
+    response,
+    name,
+    didSucceed;
+
+    cordova.callbacks[callbackId] = {
+        success: success,
+        fail: fail
+    };
+
+    request.addParam("callbackId", callbackId);
+
+    for (name in args) {
+        if (Object.hasOwnProperty.call(args, name)) {
+            request.addParam(name, args[name]);
+        }
+    }
+
+    response = request.makeSyncCall();
+
+    if (response.code < 0) {
+        if (fail) {
+            fail(response.msg, response);
+        }
+        delete cordova.callbacks[callbackId];
+    } else {
+        didSucceed = response.code === cordova.callbackStatus.OK || response.code === cordova.callbackStatus.NO_RESULT;
+        cordova.callbackFromNative(
+            callbackId,
+            success,
+            response.code,
+            [ didSucceed ? response.data : response.msg ],
+            !!response.keepCallback
+        );
+    }
+
+};

http://git-wip-us.apache.org/repos/asf/cordova-js/blob/09585fba/lib/blackberry10/platform.js
----------------------------------------------------------------------
diff --git a/lib/blackberry10/platform.js b/lib/blackberry10/platform.js
index 96f9a66..c450409 100644
--- a/lib/blackberry10/platform.js
+++ b/lib/blackberry10/platform.js
@@ -20,8 +20,11 @@
 */
 
 module.exports = {
+
     id: "blackberry10",
+
     bootstrap: function() {
+
         var cordova = require('cordova'),
             channel = require('cordova/channel'),
             addDocumentEventListener = document.addEventListener,
@@ -67,90 +70,14 @@ module.exports = {
             }
         }
 
-        function RemoteFunctionCall(functionUri) {
-            var params = {};
-
-            function composeUri() {
-                return "http://localhost:8472/" + functionUri;
-            }
-
-            function createXhrRequest(uri, isAsync) {
-                var request = new XMLHttpRequest();
-                request.open("POST", uri, isAsync);
-                request.setRequestHeader("Content-Type", "application/json");
-                return request;
-            }
-
-            this.addParam = function (name, value) {
-                params[name] = encodeURIComponent(JSON.stringify(value));
-            };
-
-            this.makeSyncCall = function (success, error) {
-                var requestUri = composeUri(),
-                request = createXhrRequest(requestUri, false),
-                response,
-                errored,
-                cb,
-                data;
-
-                request.send(JSON.stringify(params));
-                response = JSON.parse(decodeURIComponent(request.responseText) || "null");
-                return response;
-            };
-        }
-
-        window.webworks = {
-            exec: function (success, fail, service, action, args) {
-                var uri = service + "/" + action,
-                request = new RemoteFunctionCall(uri),
-                callbackId = service + cordova.callbackId++,
-                response,
-                name,
-                didSucceed;
-
-                for (name in args) {
-                    if (Object.hasOwnProperty.call(args, name)) {
-                        request.addParam(name, args[name]);
-                    }
-                }
-
-                cordova.callbacks[callbackId] = {success:success, fail:fail};
-                request.addParam("callbackId", callbackId);
-
-                response = request.makeSyncCall();
-
-                //Old WebWorks Extension success
-                if (response.code === 42) {
-                    if (success) {
-                        success(response.data, response);
-                    }
-                    delete cordova.callbacks[callbackId];
-                } else if (response.code < 0) {
-                    if (fail) {
-                        fail(response.msg, response);
-                    }
-                    delete cordova.callbacks[callbackId];
-                } else {
-                    didSucceed = response.code === cordova.callbackStatus.OK || response.code === cordova.callbackStatus.NO_RESULT;
-                    cordova.callbackFromNative(callbackId, didSucceed, response.code, [ didSucceed ? response.data : response.msg ], !!response.keepCallback);
-                }
-            },
-            defineReadOnlyField: function (obj, field, value) {
-                Object.defineProperty(obj, field, {
-                    "value": value,
-                    "writable": false
-                });
-            }
-        };
-
         //map blackberry.event to document for backwards compatibility
         if (!window.blackberry) {
             window.blackberry = {};
         }
-        window.blackberry.event = 
+        window.blackberry.event =
         {
-            addEventListner: document.addEventListener,
+            addEventListener: document.addEventListener,
             removeEventListener: document.removeEventListener
-        }
+        };
     }
 };