You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/03/25 07:16:38 UTC
[GitHub] [shardingsphere] Amulya-coder opened a new pull request #16365: Add SQL parser test case for `ALTER INSTANCE instanceId SET XA_RECOVERY_NODES = value1,value2.`
Amulya-coder opened a new pull request #16365:
URL: https://github.com/apache/shardingsphere/pull/16365
Fixes #16357.
Changes proposed in this pull request:
- Update line 104 `alter-instance sql-case-id="alter-instance-xa-recovery-nodes"`
- Update line 55 `distsql-case id="alter-instance-xa-recovery-nodes`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] lanchengx commented on a change in pull request #16365: Add SQL parser test case for `ALTER INSTANCE instanceId SET XA_RECOVERY_NODES = value1,value2.`
Posted by GitBox <gi...@apache.org>.
lanchengx commented on a change in pull request #16365:
URL: https://github.com/apache/shardingsphere/pull/16365#discussion_r835165939
##########
File path: shardingsphere-test/shardingsphere-parser-test/src/main/resources/sql/supported/ral/common.xml
##########
@@ -52,6 +52,6 @@
<distsql-case id="prepare-distsql" value="PREPARE DISTSQL" />
<distsql-case id="apply-distsql" value="APPLY DISTSQL" />
<distsql-case id="discard-distsql" value="DISCARD DISTSQL" />
- <distsql-case id="alter-instance-xa-recovery-nodes" value="ALTER INSTANCE 1.2.3.4@3307 SET XA_RECOVERY_NODES=1.2.3.4@3308" />
+ <distsql-case id="alter-instance-xa-recovery-nodes" value="ALTER INSTANCE 1.2.3.4@3307 SET XA_RECOVERY_NODES=1.2.3.4@3308,1.2.3.4@3307" />
Review comment:
This case might be better as a new test case, and it may need a new name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] lanchengx merged pull request #16365: Add SQL parser test case for `ALTER INSTANCE instanceId SET XA_RECOVERY_NODES = value1,value2.`
Posted by GitBox <gi...@apache.org>.
lanchengx merged pull request #16365:
URL: https://github.com/apache/shardingsphere/pull/16365
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Amulya-coder commented on a change in pull request #16365: Add SQL parser test case for `ALTER INSTANCE instanceId SET XA_RECOVERY_NODES = value1,value2.`
Posted by GitBox <gi...@apache.org>.
Amulya-coder commented on a change in pull request #16365:
URL: https://github.com/apache/shardingsphere/pull/16365#discussion_r835712323
##########
File path: shardingsphere-test/shardingsphere-parser-test/src/main/resources/sql/supported/ral/common.xml
##########
@@ -52,6 +52,6 @@
<distsql-case id="prepare-distsql" value="PREPARE DISTSQL" />
<distsql-case id="apply-distsql" value="APPLY DISTSQL" />
<distsql-case id="discard-distsql" value="DISCARD DISTSQL" />
- <distsql-case id="alter-instance-xa-recovery-nodes" value="ALTER INSTANCE 1.2.3.4@3307 SET XA_RECOVERY_NODES=1.2.3.4@3308" />
+ <distsql-case id="alter-instance-xa-recovery-nodes" value="ALTER INSTANCE 1.2.3.4@3307 SET XA_RECOVERY_NODES=1.2.3.4@3308,1.2.3.4@3307" />
Review comment:
@lanchengx could you guide me on how can I add a new test case here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Amulya-coder commented on pull request #16365: Add SQL parser test case for `ALTER INSTANCE instanceId SET XA_RECOVERY_NODES = value1,value2.`
Posted by GitBox <gi...@apache.org>.
Amulya-coder commented on pull request #16365:
URL: https://github.com/apache/shardingsphere/pull/16365#issuecomment-1086589193
Hi @lanchengx, I have updated the pr but one check is failing could you please tell me why it's failing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] lanchengx commented on a change in pull request #16365: Add SQL parser test case for `ALTER INSTANCE instanceId SET XA_RECOVERY_NODES = value1,value2.`
Posted by GitBox <gi...@apache.org>.
lanchengx commented on a change in pull request #16365:
URL: https://github.com/apache/shardingsphere/pull/16365#discussion_r836162362
##########
File path: shardingsphere-test/shardingsphere-parser-test/src/main/resources/sql/supported/ral/common.xml
##########
@@ -52,6 +52,6 @@
<distsql-case id="prepare-distsql" value="PREPARE DISTSQL" />
<distsql-case id="apply-distsql" value="APPLY DISTSQL" />
<distsql-case id="discard-distsql" value="DISCARD DISTSQL" />
- <distsql-case id="alter-instance-xa-recovery-nodes" value="ALTER INSTANCE 1.2.3.4@3307 SET XA_RECOVERY_NODES=1.2.3.4@3308" />
+ <distsql-case id="alter-instance-xa-recovery-nodes" value="ALTER INSTANCE 1.2.3.4@3307 SET XA_RECOVERY_NODES=1.2.3.4@3308,1.2.3.4@3307" />
Review comment:
@Amulya-coder Keep the original test and add a new line below it as a new test case.
The content is ` <distsql-case id="alter-instance-xa-recovery-nodes-with-multiple-values" value="ALTER INSTANCE 1.2.3.4@3307 SET XA_RECOVERY_NODES=1.2.3.4@3308,1.2.3.4@3307 " />`
In addition, you need to add the expected result in `shardingsphere-test/shardingsphere-parser-test/src/main/resources/case/ral/common.xml`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #16365: Add SQL parser test case for `ALTER INSTANCE instanceId SET XA_RECOVERY_NODES = value1,value2.`
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #16365:
URL: https://github.com/apache/shardingsphere/pull/16365#issuecomment-1079125193
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/16365?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16365](https://codecov.io/gh/apache/shardingsphere/pull/16365?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9af9964) into [master](https://codecov.io/gh/apache/shardingsphere/commit/14b071fa7cc68afaf13c32a1df3829e9afa10849?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (14b071f) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #16365 +/- ##
============================================
- Coverage 60.83% 60.80% -0.03%
- Complexity 2076 2086 +10
============================================
Files 3307 3312 +5
Lines 50002 50079 +77
Branches 8583 8593 +10
============================================
+ Hits 30417 30451 +34
- Misses 17033 17082 +49
+ Partials 2552 2546 -6
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/16365?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...d/text/distsql/ral/common/hint/HintSourceType.java](https://codecov.io/gh/apache/shardingsphere/pull/16365/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL2NvbW1vbi9oaW50L0hpbnRTb3VyY2VUeXBlLmphdmE=) | `0.00% <0.00%> (-42.86%)` | :arrow_down: |
| [...manager/standalone/lock/StandaloneLockContext.java](https://codecov.io/gh/apache/shardingsphere/pull/16365/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLXR5cGUvc2hhcmRpbmdzcGhlcmUtc3RhbmRhbG9uZS1tb2RlL3NoYXJkaW5nc3BoZXJlLXN0YW5kYWxvbmUtbW9kZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21hbmFnZXIvc3RhbmRhbG9uZS9sb2NrL1N0YW5kYWxvbmVMb2NrQ29udGV4dC5qYXZh) | `22.22% <0.00%> (-11.12%)` | :arrow_down: |
| [.../persist/service/SchemaMetaDataPersistService.java](https://codecov.io/gh/apache/shardingsphere/pull/16365/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvbWV0YWRhdGEvcGVyc2lzdC9zZXJ2aWNlL1NjaGVtYU1ldGFEYXRhUGVyc2lzdFNlcnZpY2UuamF2YQ==) | `48.97% <0.00%> (-7.55%)` | :arrow_down: |
| [...roxy/frontend/mysql/err/MySQLErrPacketFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/16365/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Byb3h5L2Zyb250ZW5kL215c3FsL2Vyci9NeVNRTEVyclBhY2tldEZhY3RvcnkuamF2YQ==) | `57.89% <0.00%> (-3.22%)` | :arrow_down: |
| [...sql/type/ShowSlaveStatusDatabaseDiscoveryType.java](https://codecov.io/gh/apache/shardingsphere/pull/16365/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZGItZGlzY292ZXJ5L3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1wcm92aWRlci9zaGFyZGluZ3NwaGVyZS1kYi1kaXNjb3ZlcnktbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiZGlzY292ZXJ5L215c3FsL3R5cGUvU2hvd1NsYXZlU3RhdHVzRGF0YWJhc2VEaXNjb3ZlcnlUeXBlLmphdmE=) | `36.73% <0.00%> (-1.57%)` | :arrow_down: |
| [...discovery/mysql/type/MGRDatabaseDiscoveryType.java](https://codecov.io/gh/apache/shardingsphere/pull/16365/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZGItZGlzY292ZXJ5L3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1wcm92aWRlci9zaGFyZGluZ3NwaGVyZS1kYi1kaXNjb3ZlcnktbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiZGlzY292ZXJ5L215c3FsL3R5cGUvTUdSRGF0YWJhc2VEaXNjb3ZlcnlUeXBlLmphdmE=) | `41.23% <0.00%> (-0.87%)` | :arrow_down: |
| [...coordinator/future/lock/DistributeLockContext.java](https://codecov.io/gh/apache/shardingsphere/pull/16365/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLXR5cGUvc2hhcmRpbmdzcGhlcmUtY2x1c3Rlci1tb2RlL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItbW9kZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21hbmFnZXIvY2x1c3Rlci9jb29yZGluYXRvci9mdXR1cmUvbG9jay9EaXN0cmlidXRlTG9ja0NvbnRleHQuamF2YQ==) | `15.25% <0.00%> (-0.82%)` | :arrow_down: |
| [...query/extended/parse/PostgreSQLComParsePacket.java](https://codecov.io/gh/apache/shardingsphere/pull/16365/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGIvcHJvdG9jb2wvcG9zdGdyZXNxbC9wYWNrZXQvY29tbWFuZC9xdWVyeS9leHRlbmRlZC9wYXJzZS9Qb3N0Z3JlU1FMQ29tUGFyc2VQYWNrZXQuamF2YQ==) | `92.85% <0.00%> (-0.48%)` | :arrow_down: |
| [...he/shardingsphere/mode/manager/ContextManager.java](https://codecov.io/gh/apache/shardingsphere/pull/16365/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvbWFuYWdlci9Db250ZXh0TWFuYWdlci5qYXZh) | `69.43% <0.00%> (-0.27%)` | :arrow_down: |
| [...gsphere/mode/metadata/MetaDataContextsBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/16365/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvbWV0YWRhdGEvTWV0YURhdGFDb250ZXh0c0J1aWxkZXIuamF2YQ==) | `78.12% <0.00%> (ø)` | |
| ... and [32 more](https://codecov.io/gh/apache/shardingsphere/pull/16365/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/16365?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/16365?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [14b071f...9af9964](https://codecov.io/gh/apache/shardingsphere/pull/16365?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org