You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/09/16 07:30:22 UTC

[GitHub] [skywalking] LIU-WEI-git opened a new issue #7723: [Bug] H2LogQueryDAO and LogQuery don't support fuzzy query of AbstractLogRecord.CONTENT

LIU-WEI-git opened a new issue #7723:
URL: https://github.com/apache/skywalking/issues/7723


   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Apache SkyWalking Component
   
   OAP server (apache/skywalking)
   
   ### What happened
   
   Both of [H2LogQueryDAO](https://github.com/apache/skywalking/blob/92f0ebf126fe242ee30f8ab8106b41f8ff39d656/oap-server/server-storage-plugin/storage-jdbc-hikaricp-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/h2/dao/H2LogQueryDAO.java#L87) (H2 storage plugin) and [LogQuery](https://github.com/apache/skywalking/blob/92f0ebf126fe242ee30f8ab8106b41f8ff39d656/oap-server/server-storage-plugin/storage-influxdb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/influxdb/query/LogQuery.java#L83) (InfluxDB storage plugin) don't use the parameter--`keywordsOfConten`t and `excludingKeywordsOfContent`. They don't support fuzzy query of `AbstractLogRecord.CONTENT`. Related PR #6120
   
   ### What you expected to happen
   
   We should make H2LogQueryDAO and LogQuery support fuzzy query of `AbstractLogRecord.CONTENT` like [LogQueryEsDAO](https://github.com/apache/skywalking/blob/92f0ebf126fe242ee30f8ab8106b41f8ff39d656/oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/query/LogQueryEsDAO.java#L111) in ES storage plugin.
   
   ### How to reproduce
   
   As mentioned above.
   
   ### Anything else
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #7723: [Bug] H2LogQueryDAO and LogQuery don't support fuzzy query of AbstractLogRecord.CONTENT

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7723:
URL: https://github.com/apache/skywalking/issues/7723#issuecomment-920662399


   This is not a bug, it is designed likr this. Check the APIs, they response to UI whether this storage supports content fuzzy query.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] LIU-WEI-git commented on issue #7723: [Bug] H2LogQueryDAO and LogQuery don't support fuzzy query of AbstractLogRecord.CONTENT

Posted by GitBox <gi...@apache.org>.
LIU-WEI-git commented on issue #7723:
URL: https://github.com/apache/skywalking/issues/7723#issuecomment-920664288


   Got it. Thanks for your explanation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] LIU-WEI-git closed issue #7723: [Bug] H2LogQueryDAO and LogQuery don't support fuzzy query of AbstractLogRecord.CONTENT

Posted by GitBox <gi...@apache.org>.
LIU-WEI-git closed issue #7723:
URL: https://github.com/apache/skywalking/issues/7723


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] kezhenxu94 commented on issue #7723: [Bug] H2LogQueryDAO and LogQuery don't support fuzzy query of AbstractLogRecord.CONTENT

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #7723:
URL: https://github.com/apache/skywalking/issues/7723#issuecomment-920661941


   We don't support fuzzy search on the 2 storages because they are not good at indexing and searching, or is poor performant, or is not recommended in production environment, I don't know how you will implement this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org