You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/01/13 12:00:34 UTC
[GitHub] [apisix-docker] juzhiyuan commented on a change in pull request #117: feat: Support ENABLE_PROXY argument at building phrase for mirror switch
juzhiyuan commented on a change in pull request #117:
URL: https://github.com/apache/apisix-docker/pull/117#discussion_r556468289
##########
File path: README.md
##########
@@ -20,7 +20,7 @@ export APISIX_VERSION=master
docker build -t apisix:${APISIX_VERSION}-alpine --build-arg APISIX_VERSION=${APISIX_VERSION} -f alpine/Dockerfile alpine
```
-> Note: For Chinese users, building the image with the build argument `ENABLE_PROXY=true` is always recommended to accelerate the progress.
+> Note: For Chinese users, the following command `docker build -t apisix:${APISIX_VERSION}-alpine --build-arg APISIX_VERSION=${APISIX_VERSION} --build-arg ENABLE_PROXY=true -f alpine/Dockerfile alpine` is always recommended. The additional build argument `ENABLE_PROXY=true` will enable proxy to definitely accelerate the progress.
Review comment:
too long to read 🤔
##########
File path: README.md
##########
@@ -20,7 +20,7 @@ export APISIX_VERSION=master
docker build -t apisix:${APISIX_VERSION}-alpine --build-arg APISIX_VERSION=${APISIX_VERSION} -f alpine/Dockerfile alpine
```
-> Note: For Chinese users, building the image with the build argument `ENABLE_PROXY=true` is always recommended to accelerate the progress.
+> Note: For Chinese users, the following command `docker build -t apisix:${APISIX_VERSION}-alpine --build-arg APISIX_VERSION=${APISIX_VERSION} --build-arg ENABLE_PROXY=true -f alpine/Dockerfile alpine` is always recommended. The additional build argument `ENABLE_PROXY=true` will enable proxy to definitely accelerate the progress.
Review comment:
```suggestion
**Note:** For Chinese, the following command is always recommended. The additional build argument `ENABLE_PROXY=true` will enable proxy to definitely accelerate the progress.
```sh
$ docker build -t apisix:${APISIX_VERSION}-alpine --build-arg APISIX_VERSION=${APISIX_VERSION} --build-arg ENABLE_PROXY=true -f alpine/Dockerfile alpine
```
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org